Closed (fixed)
Project:
Advanced CSS/JS Aggregation
Version:
7.x-2.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
26 May 2014 at 16:32 UTC
Updated:
14 Jun 2014 at 01:10 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
socialnicheguru commentedThis is caused by advagg when js is enabled even if no other js options are selected on admin/config/development/performance/advagg/mod
If you want to edit sharethis on it's settings page, disable advagg.
There are no issues with the sharethis widget as it appears on other pages.
Do not use any of the settings under "Optimize JavaScript Ordering" message.js will not show up.
Comment #2
mikeytown2 commentedMoving this issue into the AdvAgg queue to see if I can special case this.
Comment #3
mikeytown2 commentedI can repo this by enabling "Deferred JavaScript Execution: Add The defer Tag To All Script Tags"
Comment #4
mikeytown2 commentedOK so the issue is that sharethis uses inline javascript inside of the content. If you move all scripts to the footer and "Put a wrapper around inline JS if it was added in the content section incorrectly" is not checked OR "Deferred JavaScript Execution: Add The defer Tag To All Script Tags" is checked then this can happen. I'll look into adding a try catch block to try it again 1 second later, for a total of like 5 times.
Note that "Deferred JavaScript Execution: Add The defer Tag To All Script Tags" will only cause intermittent issues IF "Put a wrapper around inline JS if it was added in the content section incorrectly" is checked.
Comment #7
mikeytown2 commentedThese patches have been committed fixing this issue. Be sure that the "Put a wrapper around inline JS if it was added in the content section incorrectly" setting is checked if "Move JS to the footer" is set to "All". I ended up using a try catch block that seems to fix the issue in this case.