When working with Colorbox, it would be useful if there was a way to load the functionality on demand, rather than only when it's hardcoded via specific settings.

CommentFileSizeAuthor
#3 colorbox-n2272549-3.patch1.15 KBdamienmckenna
#1 colorbox-n2272549-1.patch1.14 KBdamienmckenna

Comments

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Active » Needs review
StatusFileSize
new colorbox-n2272549-1.patch1.14 KB

This adds an argument to _colorbox_doheader() that allows the code to be loaded by another module.

neslee canil pinto’s picture

neslee canil pinto
he/him
Primary language English
commented
Status: Needs review » Needs work

Patch Failed to apply.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs work » Needs review
StatusFileSize
new colorbox-n2272549-3.patch1.15 KB

Rerolled.

  • paulmckibben committed f696ca4b on 7.x-2.x 
    Issue #2272549 by DamienMcKenna, paulmckibben: API to load Colorbox on...
paulmckibben’s picture

paulmckibben
he/him
Primary language English
Location Atlanta, GA
commented
Status: Needs review » Fixed

@DamienMcKenna Thanks for the patch. I have committed it to the 7.x-2.x branch.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.