Use iterator_count() instead of count() in MigrateTestCase::queryResultTest.

CommentFileSizeAuthor
#4 2166875-migrate-languages-25.patch13.78 KBpenyaskito
#1 2272219-1.patch1.02 KBpenyaskito

Comments

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾 Seville 💃 Andalusia, UTC+2 🇪🇺
commented
Status: Active » Needs review
StatusFileSize
new 2272219-1.patch1.02 KB
benjy’s picture

benjy commented

Can you give an example of why this is needed? How have the tests been passing all the time if the number of expected results were incorrect?

Status: Needs review » Needs work

The last submitted patch, 1: 2272219-1.patch, failed testing.

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾 Seville 💃 Andalusia, UTC+2 🇪🇺
commented
Status: Needs work » Needs review
StatusFileSize
new 2166875-migrate-languages-25.patch13.78 KB

Uploading the patch that caused the failures for me (see #2166875: Migrate D6 languages) just for the sake of testing against core in testbots.

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾 Seville 💃 Andalusia, UTC+2 🇪🇺
commented
Status: Needs review » Needs work

#2 @benjy: I'm as confused as you are. Probably core is right. I don't really expect this to be committed, I just need to understand why it happens and leave this documented somewhere.

The last submitted patch, 4: 2166875-migrate-languages-25.patch, failed testing.

Status: Needs work » Needs review

penyaskito queued 4: 2166875-migrate-languages-25.patch for re-testing.

Status: Needs review » Needs work

The last submitted patch, 4: 2166875-migrate-languages-25.patch, failed testing.

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾 Seville 💃 Andalusia, UTC+2 🇪🇺
commented
Status: Needs work » Closed (works as designed)

So my problem was that I had not overriden count(). It is still unknown why iterator_count() and count() returned different results, but the problem is now gone.