Comments

Nebel54’s picture

Nebel54
Primary language German
Location Vienna
CreditAttribution: Nebel54 commented

Pull request added at: https://github.com/fago/rules/pull/7

The unittest does not run through right now, because aliasManager->getAliasByPath() always returns the original path.

Nebel54’s picture

Nebel54
Primary language German
Location Vienna
CreditAttribution: Nebel54 commented
Status: Active » Needs review
fago’s picture

fago
Primary language German
Location Vienna
CreditAttribution: fago commented
Status: Needs review » Needs work

Seems to fail. I added some comments also, see PR.

paranojik’s picture

paranojik CreditAttribution: paranojik commented
Status: Needs work » Needs review

Another pull request added at: https://github.com/fago/rules/pull/31.

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
CreditAttribution: klausi commented
Status: Needs review » Fixed

This has been comitted.

fubhy’s picture

fubhy CreditAttribution: fubhy commented
Assigned: Nebel54 » Unassigned

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.