ManageFieldsTest should not care about order of operations all the time

New contributor - looking into this.

File in question is now in ./core/modules/field_ui/src/Tests/

Okay, the patch passed but it is logically incorrect. With this patch it is possible for these 3 assertions to not run at all. the correct solution is to find a way to index the array on some static value. I will keep working on this.

I reviewed this, and logically it looks fine. Not sure if we're covering all the cases.

I ran tests with:
php core/scripts/run-tests.sh --class "Drupal\field_ui\Tests\ManageFieldsTest"

And got the following error:

Drupal test run
---------------

Tests to be run:
  - Drupal\field_ui\Tests\ManageFieldsTest

Test run started:
  Thursday, July 17, 2014 - 10:32

Test summary
------------


Fatal error: Call to a member function getSetting() on a non-object in /var/www/drupal/d8/core/modules/field_ui/src/Tests/ManageFieldsTest.php on line 254

Call Stack:
    0.0010     392608   1. {main}() /var/www/drupal/d8/core/scripts/run-tests.sh:0
    0.4269   14184200   2. simpletest_script_run_one_test() /var/www/drupal/d8/core/scripts/run-tests.sh:36
    0.4334   15658528   3. Drupal\simpletest\TestBase->run() /var/www/drupal/d8/core/scripts/run-tests.sh:626
   11.3195   48783680   4. Drupal\field_ui\Tests\ManageFieldsTest->testCRUDFields() /var/www/drupal/d8/core/modules/simpletest/src/TestBase.php:860
   11.3287   48616464   5. Drupal\field_ui\Tests\ManageFieldsTest->updateField() /var/www/drupal/d8/core/modules/field_ui/src/Tests/ManageFieldsTest.php:72
   11.3321   48635704   6. Drupal\field_ui\Tests\ManageFieldsTest->assertFieldSettings() /var/www/drupal/d8/core/modules/field_ui/src/Tests/ManageFieldsTest.php:162

FATAL Drupal\field_ui\Tests\ManageFieldsTest: test runner returned a non-zero error code (255).
- Found database prefix 'simpletest808062' for test ID 3.
[17-Jul-2014 10:32:23 Europe/Copenhagen] PHP Fatal error:  Call to a member function getSetting() on a non-object in /var/www/drupal/d8/core/modules/field_ui/src/Tests/ManageFieldsTest.php on line 254
[17-Jul-2014 10:32:23 Europe/Copenhagen] PHP Stack trace:
[17-Jul-2014 10:32:23 Europe/Copenhagen] PHP   1. {main}() /var/www/drupal/d8/core/scripts/run-tests.sh:0
[17-Jul-2014 10:32:23 Europe/Copenhagen] PHP   2. simpletest_script_run_one_test() /var/www/drupal/d8/core/scripts/run-tests.sh:36
[17-Jul-2014 10:32:23 Europe/Copenhagen] PHP   3. Drupal\simpletest\TestBase->run() /var/www/drupal/d8/core/scripts/run-tests.sh:626
[17-Jul-2014 10:32:23 Europe/Copenhagen] PHP   4. Drupal\field_ui\Tests\ManageFieldsTest->testCRUDFields() /var/www/drupal/d8/core/modules/simpletest/src/TestBase.php:860
[17-Jul-2014 10:32:23 Europe/Copenhagen] PHP   5. Drupal\field_ui\Tests\ManageFieldsTest->updateField() /var/www/drupal/d8/core/modules/field_ui/src/Tests/ManageFieldsTest.php:72
[17-Jul-2014 10:32:23 Europe/Copenhagen] PHP   6. Drupal\field_ui\Tests\ManageFieldsTest->assertFieldSettings() /var/www/drupal/d8/core/modules/field_ui/src/Tests/ManageFieldsTest.php:162

- Removed test site directory.
- Removed 58 leftover tables.

Test run duration: 11 sec

I don't know if this is related, but its the same file. I'm setting this issue back to needs work.

Added an additional test because if we change the label on the links by accident, the test won't cover it.

rerolled...

I will re-roll #10

Here is re-rolled patch #10, with additional break; at the and of case 'Delete instance.':

The error is due to the fact that 'Edit field settings' was changed to 'Edit storage settings' in issue 2312093:

https://www.drupal.org/node/2312093
https://github.com/drupal/drupal/commit/1476c56c62e4d84ef3e9a57029a92b1f...

Re-rolling with that minor change.

Last patch applies; no reroll needed.

Good work @charginghawk! Thanks to you I discovered that all dropdown menu titles was changed in #2312093: Rename FieldInstanceConfig to FieldConfig. I've updated patch - should be ok right now.

Good to go

+++ b/core/modules/field_ui/src/Tests/ManageFieldsTest.php
@@ -122,11 +122,29 @@ function manageFieldsPage($type = '') {
     $result = $this->xpath('//ul[@class = "dropbutton"]/li/a');
...
+    foreach ($result as $res) {

Rather than the variable name of $result / $res how about $operation_links / $link

Here the patch.

#25 follows alexpott suggestion, nothing more, so I'm bumping it back to RTBC.

Looks good!

Committed and pushed to 8.0.x. Thanks!