Hey there,

for a customer, I needed to extend this module with picture support. It took me a while, but I figured out that the module already has a partly implementation of the picture module. I extended, fixed it and on their website, it is working very well.

Please review the patch!

Greetings,
axe312

CommentFileSizeAuthor
#8 field_slideshow-enable-picture-support-2268419-8.patch4.71 KBjohnpitcairn
#6 field_slideshow-enable_picture_support-1.patch4.38 KBalexspl
field_slideshow-enable_picture_support.patch4.36 KBaxe312

Comments

axe312’s picture

axe312 commented
Status: Active » Needs review
nicolas bouteille’s picture

nicolas bouteille commented

Great this is exactly what I need!
Unfortunately I get an AJAX pop up error message when saving the field's slideshow formatter settings and selecting the Picture group.

An AJAX HTTP error occurred.
HTTP Result Code: 500
Debugging information follows.
Path: /system/ajax
StatusText: Service unavailable (with message)
ResponseText: Recoverable fatal error: Object of class stdClass could not be converted to string in DatabaseStatementBase->execute() (line 2171 of /...something.../includes/database/database.inc).

nicolas bouteille’s picture

nicolas bouteille commented

looks like Picture integrates well with Flexslider which has a Flexslider Field submodule... I'll have to adapt all my css but it is working.

nicolas bouteille’s picture

nicolas bouteille commented
Status: Needs review » Needs work
axe312’s picture

axe312 commented
Status: Needs work » Postponed (maintainer needs more info)

I testet it via simplytestme and i got no error in the field ui form.

Does your error only occur when you have the patch applied?
Did the patch apply without errors?

alexspl’s picture

alexspl commented
Status: Postponed (maintainer needs more info) » Needs review
StatusFileSize
new field_slideshow-enable_picture_support-1.patch4.38 KB

Here's a solution that worked for me.
One small modification was to line 478:
from

$breakpoint_group = breakpoints_breakpoint_group_load($picture_mapping->breakpoint_group);

to

$breakpoint_group = breakpoints_breakpoint_group_load($picture_mapping->breakpoint_group->machine_name);
johnpitcairn’s picture

johnpitcairn commented
Status: Needs review » Needs work

Patch at #6 does not apply.

johnpitcairn’s picture

johnpitcairn commented
Version: 7.x-1.x-dev » 7.x-2.x-dev
Status: Needs work » Needs review
StatusFileSize
new field_slideshow-enable-picture-support-2268419-8.patch4.71 KB

Patch rerolled for 7.x-2.x-dev. Works for me, using a field collection.

johnpitcairn’s picture

johnpitcairn commented
Assigned: axe312 » Unassigned
johnpitcairn’s picture

johnpitcairn commented
Status: Needs review » Reviewed & tested by the community

We have this in production at http://www.strategi.co.nz. I'm going to take a punt and mark it RTBC.

The last submitted patch, field_slideshow-enable_picture_support.patch, failed testing.

The last submitted patch, 6: field_slideshow-enable_picture_support-1.patch, failed testing.

johnpitcairn’s picture

johnpitcairn commented
Status: Reviewed & tested by the community » Needs work

Grrr.

johnpitcairn’s picture

johnpitcairn commented

Grrr.

Status: Needs work » Needs review

John Pitcairn queued 8: field_slideshow-enable-picture-support-2268419-8.patch for re-testing.

John Pitcairn queued 8: field_slideshow-enable-picture-support-2268419-8.patch for re-testing.

johnpitcairn’s picture

johnpitcairn commented
Status: Needs review » Reviewed & tested by the community
ajits’s picture

ajits
he/him
Primary language Marathi
Location India
commented
Status: Reviewed & tested by the community » Needs review

Cannot RTBC your own patch ;-)

johnpitcairn’s picture

johnpitcairn commented

It's axe312's patch, I just updated it to apply to latest dev.

johnpitcairn’s picture

johnpitcairn commented

removed

lazzyvn’s picture

lazzyvn commented

#8 works fine
I think it have to add to new version.
Thanks .

lamp5’s picture

lamp5
Primary language Polish
Location Rzeszow
commented
Status: Needs review » Closed (outdated)