Upload a file called "a b+c d+e f+g.jpg" and watch core looks for a file called "a b c d e f g.jpg". Solution is to search using file_scan_directory() the correct file replacing all spaces and plus signs with (\s+|\+)

CommentFileSizeAuthor
#6 drupal-2267639-6-decode-search-images-before-failing.patch1.67 KBmikeytown2
#4 drupal-2267639-4-decode-search-images-before-failing.patch1.92 KBmikeytown2
#1 drupal-2267639-1-search-images-with-spaces.patch1.1 KBmikeytown2

Comments

mikeytown2’s picture

mikeytown2 commented
Status: Active » Needs review
StatusFileSize
new drupal-2267639-1-search-images-with-spaces.patch1.1 KB

Patch fixes error generating image messages when the image exists and image contains plus signs in its name.

mgifford’s picture

mgifford
he/him
Primary language English
commented

Is this also an issue in D8? Doesn't seem to be.

mikeytown2’s picture

mikeytown2 commented

What's the relevant function in D8? This is an edge case, to test drop a file with pluses in the public dir and see if you can generate the image style when hitting the URL.

mikeytown2’s picture

mikeytown2 commented
Title: Image styles do not get created if the original file contains a plus sign » Image styles do not get created if the original file contains a plus sign or is double url encoded
StatusFileSize
new drupal-2267639-4-decode-search-images-before-failing.patch1.92 KB

Updated patch to incorporate double url encoded urls

mgifford’s picture

mgifford
he/him
Primary language English
commented

Great that the bots like this patch. 11 months ago I was just trying to figure out if this needed to be fixed in D8 before being backported to D7.

mikeytown2’s picture

mikeytown2 commented
StatusFileSize
new drupal-2267639-6-decode-search-images-before-failing.patch1.67 KB

Error out if the $image_uri or $derivative_uri is empty. Better handles some odd edge cases.

Status: Needs review » Closed (outdated)

Automatically closed because Drupal 7 security and bugfix support has ended as of 5 January 2025. If the issue verifiably applies to later versions, please reopen with details and update the version.