Drupal is awesome for complex websites but doesn't get much traction for simple, quick'n'dirty microsites and blogs.
One import reason, maybe even the most important reason, is that even for basic theming, a number of overrides or creation of a subtheme is necessary which is just out of scope for simple out-of-the-box sites.

Whenever I'm setting up a blog on WordPress, I just start with a fullsize JPG header background rather than just a logo.
On Drupal, I'm uploading the header image as a logo, it obviously doesn't get displayed in the background but with lots of spacing all around.
If I'm overriding the background in the theme, the position is fine but the header doesn't adapt to the background's height. Then I'm giving the header a fixed, manual height, but now the primary menu doesn't adapt. So in the end I need a whole couple of additional CSS overrides.
But then, I'm still not flexible in adhoc replacing the background image, and most technically untrained (and uninterested) admins of such microsites or blogs won't be able to replace it at all.

What I'd be expecting is a possibility just to upload a header image and be ready, just as it is possible with logo and favicon. So I think we really need something like the Noggin module in core to be more. IMHO, this is a killer feature bringing us much closer to being an alternative for Wordpress for such kind of sites.

CommentFileSizeAuthor
#12 image_header_2267011-12.patch9.92 KBkaushashah
#6 image_headers.2267011-3.patch12.64 KBWeilinggu
#2 image_headers.2267011-2.patch10.78 KBpancho
#2 interdiff.txt3.37 KBpancho
#1 image_headers.2267011-1.patch10.53 KBpancho

Comments

pancho’s picture

pancho
Location UTC+2 🇪🇺 EU
commented
Status: Active » Needs review
StatusFileSize
new image_headers.2267011-1.patch10.53 KB

Here's a patch with the basic functionality, no frills.
Doesn't automatically adapt to the image header's height, but that would probably be what we want as default behaviour.
We also might want to save the CSS rule to the filesystem so it can get aggregated.
You'll have to refresh the cached theme info before the new settings appear on Bartik's settings.

pancho’s picture

pancho
Location UTC+2 🇪🇺 EU
commented
StatusFileSize
new interdiff.txt3.37 KB
new image_headers.2267011-2.patch10.78 KB

Second step: Automatically adapt header to image height. Primary navigation buttons don't yet get pushed down.

alansaviolobo queued 2: image_headers.2267011-2.patch for re-testing.

Status: Needs review » Needs work

The last submitted patch, 2: image_headers.2267011-2.patch, failed testing.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Component: theme system » Bartik theme
Priority: Major » Normal
Issue tags: +Needs reroll

This is a good idea, and something that we could add to bartik so I'm moving it there. It won't help much on an admin theme so we can just put it in bartik theme component.

Looks like head has moved so this needs a re-roll but maybe a good opportunity to move that to bartik.

Moving the priority to normal and let the maintainer of that section to adjust the priority accordingly.

Weilinggu’s picture

Weilinggu commented
StatusFileSize
new image_headers.2267011-3.patch12.64 KB

The patch is rerolled. However, _drupal_add_css() function is removed in drupal 8 and Dynamic inline JS/CSS is no longer available. See this issue Dynamic inline JS/CSS with #attached is longer possible. Before this issue is resolved, the url and height of the image will be put in a js file added via libraries.yml(as mentioned in the patch).

Need rework after related issue is resolved.

Thanks to the help of piyuesh.

Weilinggu’s picture

Weilinggu commented
Status: Needs work » Needs review
Bojhan’s picture

Bojhan commented
Version: 8.0.x-dev » 8.1.x-dev

Status: Needs review » Needs work

The last submitted patch, 6: image_headers.2267011-3.patch, failed testing.

Weilinggu’s picture

Weilinggu commented

There is no test for image_header. Test need to be written for image_header.

kaushashah’s picture

kaushashah commented
Assigned: Unassigned » kaushashah
Issue tags: +drupalconasia2016
kaushashah’s picture

kaushashah commented
Status: Needs work » Needs review
Issue tags: -Needs reroll
StatusFileSize
new image_header_2267011-12.patch9.92 KB

Patch Rerolled.

Status: Needs review » Needs work

The last submitted patch, 12: image_header_2267011-12.patch, failed testing.

emma.maria’s picture

emma.maria
she/her
commented
Assigned: kaushashah » Unassigned
Issue tags: +Needs tests

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.0-beta1 was released on March 2, 2016, which means new developments and disruptive changes should now be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.0-beta1 was released on August 3, 2016, which means new developments and disruptive changes should now be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.0-alpha1 will be released the week of January 30, 2017, which means new developments and disruptive changes should now be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.0-alpha1 will be released the week of July 31, 2017, which means new developments and disruptive changes should now be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.0-alpha1 will be released the week of January 17, 2018, which means new developments and disruptive changes should now be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

pameeela’s picture

pameeela commented
Component: Bartik theme » Olivero theme

Moving this to Olivero since the intent was to have this feature in Drupal core, and Bartik is now in contrib. Not saying it should be added to Olivero but I think that is the only logical place to put the request?

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.

quietone’s picture

quietone commented
Status: Needs work » Postponed

The Olivero theme was approved for removal in #3590816: [policy, no patch] Deprecate Olivero and move to contrib.

This is Postponed. The status is set according to two policies. The Remove a core extension and move it to a contributed project and the Extensions approved for removal policies.

The deprecation work is in #3595082: [meta] Tasks to deprecate the Olivero theme and the removal work in #3595085: [meta] Tasks to remove the Olivero theme.