Hi.

When choosing to use the VideoJS CDN integration, the module still complains on the site status page that the library was not found. This makes an error message appear (something is wrong with your site install) eventhough everything is in fact OK.

The hook_requirements implementation should check if the site uses the CDN option. If so, it should not do any requirement checks.

CommentFileSizeAuthor
#1 videojs.install.hook_requirements_does_not_check_cdn_option_2266005_1.patch488 byteswadmiraal

Comments

wadmiraal’s picture

wadmiraal commented
StatusFileSize
new videojs.install.hook_requirements_does_not_check_cdn_option_2266005_1.patch488 bytes

Here's a patch.

brunodbo’s picture

brunodbo
he/him
commented
Status: Active » Reviewed & tested by the community

Patch works great.

jorrit’s picture

jorrit commented
Status: Reviewed & tested by the community » Fixed

Thanks for your patch. I chose to improve version detection in a different way, see http://drupalcode.org/videojs/commit/?id=adef482. I hope this works for you too.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.