Token is not expanded when sending invoice email. Used default 'Leave it empty to use the site-wide configured address.'

e.g.
[site:name] <"[site:mail]"@

Thanks

CommentFileSizeAuthor
#12 commerce_invoice_receipt-email-sender-2265943-12.patch545 bytesrooby
#1 commerce_invoice_receipt-email-sender-2265943-1.patch550 bytesinterlated

Comments

interlated’s picture

interlated commented
StatusFileSize
new commerce_invoice_receipt-email-sender-2265943-1.patch550 bytes

Fix is to take out the default. Standardises implementation to be the same as mimeemail.

interlated’s picture

interlated commented
Status: Active » Needs review
daglees’s picture

daglees
he/him
Primary language English
commented

I'll be testing this today.

daglees’s picture

daglees
he/him
Primary language English
commented

I'm unable to replicate this.

daglees’s picture

daglees
he/him
Primary language English
commented
Status: Needs review » Postponed (maintainer needs more info)
daglees’s picture

daglees
he/him
Primary language English
commented
Status: Postponed (maintainer needs more info) » Closed (cannot reproduce)
kepford’s picture

kepford commented

I can confirm that issue occurs as well as that the patch resolves the issue.

rooby’s picture

rooby commented
Status: Closed (cannot reproduce) » Reviewed & tested by the community

Reopening as there has been confirmation of the issue in #7.

I am also seeing the same problem.

rooby’s picture

rooby commented
Status: Reviewed & tested by the community » Needs review

Sorry, wrong status

Status: Needs review » Needs work

The last submitted patch, 1: commerce_invoice_receipt-email-sender-2265943-1.patch, failed testing.

rooby’s picture

rooby commented
Status: Needs work » Needs review

Strangely enough I have two copies of a site with what seems to be identical configuration and one works and the other sends unprocessed tokens.

rooby’s picture

rooby commented
Version: 7.x-1.1 » 7.x-1.x-dev
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new commerce_invoice_receipt-email-sender-2265943-12.patch545 bytes

I can confirm that if I actually set the field to "[site:name] <[site:mail]>" then it works but if I don't and use the default then it comes through to the commerce_invoice_receipt_action_mail() function as "[site:name] <[site:mail]>" and then doesn't replace properly.

If the intention is to use the default mail via the drupal_mail function then the patch in #1 should be the correct solution.

The patch fixes it for me also.

Not sure why that test is failing to apply the path. Here is a re-roll that applies without fuzz.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 12: commerce_invoice_receipt-email-sender-2265943-12.patch, failed testing.

rooby’s picture

rooby commented
Status: Needs work » Reviewed & tested by the community

That fail is odd.

  • aramboyajyan committed 63c1fc9 on 7.x-1.x authored by rooby 
    Issue #2265943 by rooby, interlated: [site:name] token in from address...
aramboyajyan’s picture

aramboyajyan commented
Status: Reviewed & tested by the community » Fixed

Committed. Thanks guys!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.