I understand that og_workflow 7.2.x is compatible with workflow 7.2.x and og 7.2.x but is og_workflow compatible with workflowfields which recommends that the workflow_node module not be used?

Comments

poindexterous’s picture

I'm curious about this as well, since I'm working on a project using workflow fields for our content moderation combined with OG groups.

danielfdsilva’s picture

I'm using it with workflow filed and seems to be working.
The only problem is the dependency of workflownode which should not be there since workflow is moving away from it.
Here's a patch that removes this dependency from the info file. The module doesn't break but this is not a definitive solution although the dependency should not be forced.

arknoll’s picture

Priority: Normal » Major
Status: Active » Needs review
StatusFileSize
new5.28 KB

I had to incorporate many more changes than just removing the dependency of workflownode to get this to work correctly. Please find attached the patch that allowed this to work with workflow field.

Sylense’s picture

This patch doesn't fix integration so that og workflow access can work with workflowfield does it? Not sure if I'm doing something wrong but I cannot get og workflow access to work correctly using workflowfield.

dzy’s picture

test that patch. but not working with workflow 2.5
need workflow state access control with og access

najamfzl’s picture

The patch in #3 does not work with Workflow 7.x-2.5. The og state transition permissions are respected but when saving the new workflow state, the state does not change.
After testing I found a strange problem, it appears that if the "author" is not included in the original workflow state transition, that og transition does not commit. E.g. if in the original workflow transition, the "author" cannot transit from "review" to "live", no matter what your og transition settings are, the og member (e.g. og content reviewer) cannot commit the state change. However, the "og content reviewer" can see the transition states in the workflow drop-down depending on the og transition settings.
P.S. It is only dependent on "author", selecting any other role in original transition do not have any effect.

zekvyrin’s picture

Issue tags: -Myo
Parent issue: #2606468: If I disable drupal aggregation/compression ModSecurity blocks my IP »
Related issues: -#2611374: [simple_gmap] Simple Google Maps

@MYO MIN OO:

Sorry if you meant otherwise, but this seems spam to me.

shenzhuxi’s picture

StatusFileSize
new7.56 KB

I briefly tried patch 3. It seems working with workflow 7.x-2.6 and 7.x-2.x.
I made a little extra modification.

zekvyrin’s picture

I've uploaded a new patch, based in #4.

I am trying to use this in a another entity and it still have some issues, as this module is taking for granted that the workflow is applied in a node. What I did:

1) updated some of its functions to include entity_type and don't assume "node"

2) patch #4 introduced a WSOD in og_access page (page arguments shouldn't be changed in og_workflow_access' hook_menu), so I corrected it.

3) In og_workflow_user_may_perform_transition, I added a check to allow non members with proper access to also be able to make the transition. In my case it's a must, as I have both members (with specific OG Roles in this group) & non members (with specific Drupal Roles) to be able to do some transitions.

4) finally, fixed some end of line white-spaces coding standards issues.

It's not yet working 100%, but the other issue I'm having is not related to this module.

shenzhuxi’s picture

Status: Needs review » Fixed

Committed

zekvyrin’s picture

Please commit it to dev version as well.

Thanks

shenzhuxi’s picture

Yes, I did.

zekvyrin’s picture

It's not committed on 7.x-2.x branch (the one that creates 7.x-2.x-dev version).
Only in master branch.

shenzhuxi’s picture

Sorry, I made a mistake. Now committed on 7.x-2.x.
Thanks.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

sozkara’s picture

Seems not working for me. Still getting "There are no states defined for this workflow."