DatabaseStorage can create the table itself. And this will make the patch over in #2262861: Add concept of collections to config storages smaller since that changes the DatabaseStorage schema.

CommentFileSizeAuthor
remove-config-snapshot-schema.patch6.09 KBalexpott

Comments

berdir’s picture

berdir
Primary language German
Location Switzerland
commented

There was some discussion about this in the issue that switched to the database backend, @sun was against this if I remember correctly, but since it was required on some cases, we now have a mixed case..

Looks fine to me but we should check the discussion/reason in the issue that added it..

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Related issues: +#2161591: Change default active config from file storage to DB storage

So we added the auto table creation in #2161591: Change default active config from file storage to DB storage - config_snapshot is not mentioned at all in that issue. Auto generation was added in comment #59 - @sun expressed reservations but in back #88 it was re-introduced by @pwolanin after discussion with @sun.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Reviewed & tested by the community

Yes, you're right, this relies on the functionality of the database storage to create whatever table name you pass it to, and if we do it for the normal table, then it's only consistent to do it here too.

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.x, thanks!

  • Commit 7bc7920 on 8.x by catch: 
    Issue #2263273 by alexpott: Config_snapshot table can be created by the...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.