I noticed multiple notices/warnings in the log about a missing calendar.png file. I tracked this down to the commerce_discount module trying to reference an image file in the date/date_api module. This was happening for me because these modules were not in the same parent directory (e.g. modules/contrib).

Attached is a patch that takes a copy of that calendar.png file and puts in the commerce_bundle/images folder and then references that in the scss / css files.

CommentFileSizeAuthor
#6 missing_calendar_png-2262225-6.patch754 bytesjoelpittet
#1 commerce_discount-missing_calendar_png-2262225-1.patch3.21 KBcaschbre

Comments

caschbre’s picture

caschbre commented
Status: Active » Needs review
StatusFileSize
new commerce_discount-missing_calendar_png-2262225-1.patch3.21 KB
bojanz’s picture

bojanz commented
Status: Needs review » Fixed

Committed, thanks.

  • bojanz committed 39d19ed on 7.x-1.x authored by caschbre 
    Issue #2262225 by caschbre: Fixed Missing calendar.png.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

alexbarrett’s picture

alexbarrett commented
Status: Closed (fixed) » Needs review

The images/calendar.png file was not committed along with the CSS changes so this issue persists in the latest dev release.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
StatusFileSize
new missing_calendar_png-2262225-6.patch754 bytes

Confirmed that image is not there but all the other changes are. Here's a patch with just that image.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented

The above may not apply... damn binaries! :(

caschbre’s picture

caschbre commented

Yeah, patch #1 contained the binary but if it's not applying, what other options do we have?

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented

@bojanz can you just copy the file from the date module and commit it to the path the patch is trying to?

Seems simpler than trying to get the patch to apply.

If you use git apply the above patch with will work but not patch -p1.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Status: Needs review » Reviewed & tested by the community

Just going to re RTBC this.

deggertsen’s picture

deggertsen commented

Patch in #6 works when applying using GIT. Thanks!

bojanz’s picture

bojanz commented
Status: Reviewed & tested by the community » Fixed

Committed that one as well. Thanks!

  • bojanz committed b1aedc7 on 7.x-1.x authored by joelpittet 
    Issue #2262225 by joelpittet, caschbre: Missing calendar.png

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.