D6->D8 Profile field (date)

I made some progress on this one today.

I've attached a patch with the fix for this, I added a static_map process plugin to the d6_user_profile_field plugin that sets the datetime_type to "date" (as opposed to the default "datetime") when migrating a D6 profile "Date" field. The only thing about this patch that bothers me a little is the fact all migrated profile fields are going to have a "datetime_type" settings (all will be set to '' except for migrated "Date" fields). Is this cool?

I am unable to determine why the existing MigrateProfilesTest passed prior to this fix, and am unable to modify the test to produce a failing test...

-mike

I think the issue with the non-failing test is that the value is migrated just fine, but since the D8 form widget is expecting a date and a time, and we're only migrating a date, the D8 display widget doesn't display a value (see this screenshot from a manual test I just ran: http://note.io/UYlf7b).

The MigrateProfileValuesTest test passes because the migrated value in the DB is exactly what is should be.

I'm thinking that I need to modify the MigrateUserProfileFieldTest to ensure we have the correct form widget type. I'll work on that next.

As for breaking the datetime_type into a separate plugin, I'll look at that after I get a failing test working.

Thanks,
-mike

Well, creating a failing MigrateUserProfileFieldTest was easy. Patch attached.

Custom plugin coming later.

Thanks,
-mike

@chx,

Before I start writing code, please let me know if this is what you're thinking...

I'm going to write a new d6 process plugin called Drupal\migrate_drupal\Plugin\migrate\Process\d6\ProfileFieldSettings

The configuration will look something like:

settings: 
  plugin: d6_profile_field_settings
  source: type

The transform() method will then just have a switch() statement that will set settings.datetype_type to "date" when type = datetime.

Am I missing anything?

Thanks,
-mike

@chx - thanks for the help.

I've attached a patch that hopefully fixes this issue. The new test passes (consider the patch in 5 the "FAIL" patch) and a manual test looks good as well.8

Thanks,
-mike

The re-roll looks fine to me, all minor changes that don't affect the overall patch logic.

Thanks,
-mike