Move Drupal\Tests\Component\Image\ImageUtilityTest to Drupal\Tests\Component\Utility\ImageTest

This still needs to happen, But it needs a reroll.

Shouldn't the file-level comment be 'Contains \Drupal\Tests\Component\Uility\ImageTest' rather than '...\Image\ImageTest'?

@tibbsa yeah! you are right, thank you!

+++ b/core/tests/Drupal/Tests/Component/Utility/ImageTest.php
@@ -0,0 +1,164 @@
-/**
- * @coversDefaultClass \Drupal\Component\Utility\Image
- * @group Image
- */
- class ImageTest extends UnitTestCase {
+/**
+ * Tests \Drupal\Component\Utility\Image.
+ *
+ * @group Utility
+ *
+ * @coversDefaultClass \Drupal\Component\Utility\Image
+ */
+class ImageTest extends UnitTestCase {

+++ b/core/tests/Drupal/Tests/Component/Utility/ImageTest.php
@@ -0,0 +1,164 @@
-  /**
-   * Tests all control flow branches in image_dimensions_scale().
-   *
-   * @dataProvider providerTestScaleDimensions
-   */
-  public function testScaleDimensions($input, $output) {
+  /**
+   * Tests all control flow branches in image_dimensions_scale().
+   *
+   * @param array $input
+   *   Array which contains input for Image::scaleDimensions().
+   * @param array $ouput
+   *   Array which contains expected output after passing
+   *   through Image::scaleDimensions. Also contains a boolean
+   *   'return_value' which should match the expected return value.
+   *
+   * @dataProvider providerTestScaleDimensions
+   *
+   * @covers ::scaleDimensions
+   */
+  public function testScaleDimensions($input, $output) {

+++ b/core/tests/Drupal/Tests/Component/Utility/ImageTest.php
@@ -0,0 +1,164 @@
-  /**
-   * Provides data for image dimension scale tests.
-   *
-   * @return array
-   *   Keyed array containing:
-   * - 'input' - Array which contains input for
-   *   Image::scaleDimensions().
-   * - 'output' - Array which contains expected output after passing
-   *   through Image::scaleDimensions. Also contains a boolean
-   *   'return_value' which should match the expected return value.
-   *
-   * @see testScaleDimensions()
-   */
-  public function providerTestScaleDimensions() {
+  /**
+   * Provides data for image dimension scale tests.
+   *
+   * @return array
+   *   Test data.
+   */
+  public function providerTestScaleDimensions() {

Some docblock changes to get in line with other PHPUnit tests.

Did some digging and I believe it is better to change the comments to:

  /**
   * Tests all control flow branches in image_dimensions_scale().
   *
   * @dataProvider providerTestScaleDimensions
   * @covers ::scaleDimensions
   */
  public function testScaleDimensions($input, $output) {

  /**
   * Provides data for image dimension scale tests.
   *
   * @return array
   *   - Array which contains input for Image::scaleDimensions().
   *   - Array which contains expected output after passing
   *     through Image::scaleDimensions. Also contains a boolean
   *     'return_value' which should match the expected return value.
   */
  public function providerTestScaleDimensions() {

@rpayanm: I think something went wrong with your patch. There is all sort of stuff that does not belong in this patch.

Sorry, I forgot git rebase 8.0.x after of git pull.

The ImageTest has been moved and renamed.
The old test file has been deleted.
The comments are all in order.
It looks good to me so I give it a RTBC.

Not downgrading but in these cases it really helps to roll patches with -C -M in order to allow for easier reviewing.

@tstoeckler you can explain more about this? it's good learn every something new!

This does more than just move.

diff --git a/core/tests/Drupal/Tests/Component/Image/ImageUtilityTest.php b/core/tests/Drupal/Tests/Component/Utility/ImageTest.php
similarity index 86%
rename from core/tests/Drupal/Tests/Component/Image/ImageUtilityTest.php
rename to core/tests/Drupal/Tests/Component/Utility/ImageTest.php
index 3c51ca9..63f20a6 100644
--- a/core/tests/Drupal/Tests/Component/Image/ImageUtilityTest.php
+++ b/core/tests/Drupal/Tests/Component/Utility/ImageTest.php
@@ -2,26 +2,30 @@
 
 /**
  * @file
- * Contains \Drupal\Tests\Component\Image\ImageUtilityTest.
+ * Contains \Drupal\Tests\Component\Utility\ImageTest.
  */
 
-namespace Drupal\Tests\Component\Image;
+namespace Drupal\Tests\Component\Utility;
 
 use Drupal\Component\Utility\Image;
 use Drupal\Tests\UnitTestCase;
 
 /**
+ * Tests \Drupal\Component\Utility\Image.
+ *
+ * @group Utility
+ *
  * @coversDefaultClass \Drupal\Component\Utility\Image
- * @group Image
  */
-class ImageUtilityTest extends UnitTestCase {
+class ImageTest extends UnitTestCase {
 
   /**
    * Tests all control flow branches in image_dimensions_scale().
    *
    * @dataProvider providerTestScaleDimensions
+   * @covers ::scaleDimensions
    */
-  function testScaleDimensions($input, $output) {
+  public function testScaleDimensions($input, $output) {
     // Process the test dataset.
     $return_value = Image::scaleDimensions($input['dimensions'], $input['width'], $input['height'], $input['upscale']);
 
@@ -39,14 +43,10 @@ function testScaleDimensions($input, $output) {
    * Provides data for image dimension scale tests.
    *
    * @return array
-   *   Keyed array containing:
-   * - 'input' - Array which contains input for
-   *   Image::scaleDimensions().
-   * - 'output' - Array which contains expected output after passing
-   *   through Image::scaleDimensions. Also contains a boolean
-   *   'return_value' which should match the expected return value.
-   *
-   * @see testScaleDimensions()
+   *   - Array which contains input for Image::scaleDimensions().
+   *   - Array which contains expected output after passing
+   *     through Image::scaleDimensions. Also contains a boolean
+   *     'return_value' which should match the expected return value.
    */
   public function providerTestScaleDimensions() {
     // Define input / output datasets to test different branch conditions.

We should have one issue to move and one issue to fix other issues.

@rpayanm read https://www.drupal.org/documentation/git/configure - specifically the bit on Optimize diffs for renamed and copied files

The ImageTest has been moved and renamed.
The old test file has been deleted.
This patch has been made with the "git mv" command.
It looks good to me so I give it a RTBC.

Tests are not covered by the beta evaluation. Committed 2c23066 and pushed to 8.0.x. Thanks!