Support from Acquia helps fund testing for Drupal Acquia logo

Comments

foreach’s picture

Issue summary: View changes
foreach’s picture

foreach’s picture

Jeff Burnz’s picture

I'll review asap, unfortunately I am flat out right now and might not get to this in the next week or so - I'd like this to go into the next release.

I also have some other code bumping around that added the new (mostly unknown) Google Font Effects, could be interesting?
https://developers.google.com/fonts/docs/getting_started#Effects

foreach’s picture

The help or my opinion is necessary?

Jeff Burnz’s picture

Both if possible :) I would love to hear your opinion on this certainly.

Another option is to change this whole Google fonts system to be like the Adaptivetheme Drupal 8 version - so you build the Google Font URL using the Google Font Builder tools (on the google fonts website) and simply paste in the whole URL string, this is better because we can avoid all these fancy settings and it vastly simplifies the code in the theme.

foreach’s picture

Sorry, not much time now.

At the expense of easy, you're right.

Have not seen a theme for Drupal 8.

Jeff Burnz’s picture

Theme is in GIT, you can download it from viewing the page "View All Releases" or pull it from GIT, however right now it could be broken against D8 head - since D8 is moving really fast right now and its hard to keep up with daily changes.