Problem/Motivation

The page cache is currently in a poor state. At least two attempts have been made to entirely rearchitect the system (#1597696: Consider whether HttpCache offers any significant benefit over the existing page cache and later #2177461: Refactor page caching into a service). However the current system suffers from several defects and one major design issue (see step 1 below). As a consequence the conversion from procedural to object-oriented code is not straight forward and risky.

Proposed resolution

In order to unblock progress it is necessary to subdivide the undertaking into multiple steps:

  1. #2257709: Remove the interdependence between the internal page cache and management of the Cache-Control header for external caches
  2. #2263981: Introduce a robust and extensible page cache-policy framework
  3. Convert the internal page cache into a service or a kernel-wrapper (possibly based on Symfony HttpCache) #2348679: Move the remaining procedural page cache code to the page cache stack middleware or #1597696: Consider whether HttpCache offers any significant benefit over the existing page cache

Related defects / issues:

Remaining tasks

User interface changes

API changes

Comments

znerol’s picture

znerol commented
Issue summary: View changes
znerol’s picture

znerol commented
Issue summary: View changes
znerol’s picture

znerol commented
Issue summary: View changes
dawehner’s picture

dawehner
Primary language German
commented

Thank you for splitting this up and making progress in multiple areas.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented

Thanks, that should make this much easier to get done! :)

znerol’s picture

znerol commented
Issue summary: View changes
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented

#2263981: Introduce a robust and extensible page cache-policy framework landed. I unpostponed #1597696: Consider whether HttpCache offers any significant benefit over the existing page cache, but since that was moved to 9.x-dev now, I wasn't sure we would be able to work on it. Crell said we can. So that's probably the current issue in focus.

znerol’s picture

znerol commented
Issue summary: View changes

#1597696: Consider whether HttpCache offers any significant benefit over the existing page cache is postponed again, therefore let's stackify the remaining procedural page cache code: #2348679: Move the remaining procedural page cache code to the page cache stack middleware

znerol’s picture

znerol commented

There is currently no progress here because #2348679: Move the remaining procedural page cache code to the page cache stack middleware is still blocked on #2347877: Move DrupalKernel::initializeCookieGlobals() into a SessionConfiguration service.

moshe weitzman’s picture

moshe weitzman commented
Status: Needs review » Active

Nothing to review here. Can we close this meta?

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented

The NR state was wrong, but the child issues are still being worked on, so I don't think we can close this just yet.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Active » Fixed

Discussed with @znerol, I think we can close this one now. #2368987: Move internal page caching to a module to avoid relying on config get on runtime is the last step, but we don't need a meta issue to track that, it wasn't even in here.

All other issues have been fixed or closed, so closing this :)

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented

And #2368987: Move internal page caching to a module to avoid relying on config get on runtime has now been committed! So definitely fine to close this. Yay!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.