https://drupal.org/node/2079005 summerises menu helper changes, the tasks themselves do things in a different in some cases removing code, in others marking it as deprecated and in others not evening doing that. This patch removes the unused code hunks and coverts some items in core that are using the procedural code still.

CommentFileSizeAuthor
#14 issue-2257395.patch5.56 KBmarcingy
#8 issue-2257395.patch6.12 KBmarcingy
#2 issue-2257395.patch5.58 KBmarcingy
#1 issue-2257395.patch5.8 KBmarcingy

Comments

marcingy’s picture

marcingy commented
Status: Active » Needs review
StatusFileSize
new issue-2257395.patch5.8 KB
marcingy’s picture

marcingy commented
StatusFileSize
new issue-2257395.patch5.58 KB
marcingy’s picture

marcingy commented
Issue tags: +@deprecated

Status: Needs review » Needs work

The last submitted patch, 2: issue-2257395.patch, failed testing.

marcingy’s picture

marcingy commented
Status: Needs work » Needs review

2: issue-2257395.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, 2: issue-2257395.patch, failed testing.

The last submitted patch, 1: issue-2257395.patch, failed testing.

marcingy’s picture

marcingy commented
Status: Needs work » Needs review
StatusFileSize
new issue-2257395.patch6.12 KB
slashrsm’s picture

slashrsm commented
Status: Needs review » Reviewed & tested by the community

Looks good.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 8: issue-2257395.patch, failed testing.

marcingy’s picture

marcingy commented
Status: Needs work » Needs review

8: issue-2257395.patch queued for re-testing.

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community

Still green...

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 8: issue-2257395.patch, failed testing.

marcingy’s picture

marcingy commented
Status: Needs work » Needs review
StatusFileSize
new issue-2257395.patch5.56 KB

So something got killed elsewhere!

Status: Needs review » Needs work

The last submitted patch, 14: issue-2257395.patch, failed testing.

marcingy’s picture

marcingy commented
Status: Needs work » Needs review

14: issue-2257395.patch queued for re-testing.

slashrsm’s picture

slashrsm commented
Status: Needs review » Reviewed & tested by the community
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.x, thanks!

marcingy’s picture

marcingy commented
Status: Fixed » Reviewed & tested by the community

I am not seeing the commit on https://drupal.org/node/3060/commits

  • Commit d633c85 on 8.x by catch: 
    Issue #2257395 by marcingy: URL helper functions were converted in an...
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

I'd committed but my pushed failed, just pushed again now.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.