[D7] OPAC Search

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxSeanFitzpatrick225700...

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Hi SeanFitzpatrick

On drupal proyect doesn't use README.md ;)

In the first post (https://drupal.org/node/2257061) put the coder reviews link. With this easier to revise.

Hi,
Thanks for your contribution.
Here is my review :

it's really weird to have a drupal_set_message in .install file with no hook wrapper. At least wrapp it in hook_install and provide the url to configuration page, otherwise it's not very helpful.
Also you need to wrap the string in t() function to allow its translation.

in opac_search_block_view, you are loading a form each time you view a block (ANY block), this is very bad for peroformance. i suggest you do this inside the case 'opac_search'

opac_search_catalog_form is not really needed in the memory all the time, and thus it should not exist in the .module file for perormance sake.
i suggest you add a mymodule.form.inc per example and include it just where you need to load the form (inside case 'opace_search' in the hook_block_view.

the .install should have a hook_uninstall where we variable_del() all variables introduced by the module

it may be very useful to validate that url is a valid one before opac_search_submit_block_form.

in opac_search_catalog_form the string in drupal_set_message should be wrapped with a t().
the url process (getting params for example) is re doing what the the function drupal_parse_url arleady does well. i suggest we relay on it for that need.

Thanks again

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.