This function performs a query each time it is called. It should implement static caching so it doesn't run duplicate queries unnecessarily.

CommentFileSizeAuthor
#1 weight-static-caching-for-settings-2256799-1.patch1.19 KBlee20

Comments

lee20’s picture

lee20 commented
Status: Active » Needs review
StatusFileSize
new weight-static-caching-for-settings-2256799-1.patch1.19 KB

Attached is a patch which implements static caching in _weight_get_settings(). It runs one query to grab all of the settings and stores the statically so redundant queries are not ran.

  • davisben committed 9271364 on 7.x-2.x authored by lee20 
    Issue #2256799 by lee20: Use static caching in _weight_get_settings().
davisben’s picture

davisben
Primary language English
Location NH, USA
commented
Status: Needs review » Fixed

Committed. Thanks for the patch!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.