Hello,

My order receipt has an "Edit view" link just above the line items. The link points to http://example.com/admin/structure/views/view/commerce_line_item_table/e... . What is causing this, and how can I eliminate it?

Thanks!

CommentFileSizeAuthor
#5 commerce_invoice_receipt-suppress_contextual_links-2255027-5.patch1.04 KBmstrelan
#3 commerce_invoice_receipt-suppress_contextual_links-2255027-3.patch604 bytesmstrelan

Comments

BernieCram’s picture

BernieCram commented

Hi Hockey2112

It sounds like the view edit shortcut which is provided by 'contextual links' module not by this module. The default permission will be that only a user with administrator role will be able to see the shortcut, so it is not something which you need to worry about unless you have gone on a permissions granting spree.

Check the permissions you have set for it at /admin/people/permissions

Bernie

daglees’s picture

daglees
he/him
Primary language English
commented
Status: Active » Closed (works as designed)
mstrelan’s picture

mstrelan commented
Status: Closed (works as designed) » Needs review
StatusFileSize
new commerce_invoice_receipt-suppress_contextual_links-2255027-3.patch604 bytes

Sorry to reopen this, but using the "Email the invoice" feature of this module an administrator with permission to view contextual links can send the invoice to the customer, or to any other email address. The resulting email includes the "Edit view" link. This is not due to frivolous permission granting. Attached patch suppresses views contextual links.

joshua.howell’s picture

joshua.howell commented

The attached patch only suppresses it in the print function, you also need to add the code to the commerce_invoice_receipt_mail function.

mstrelan’s picture

mstrelan commented
StatusFileSize
new commerce_invoice_receipt-suppress_contextual_links-2255027-5.patch1.04 KB

Here's a new patch that suppresses the link twice.

dasginganinja’s picture

dasginganinja
Primary language English
Location Bethlehem, PA
commented
Version: 7.x-1.1 » 7.x-1.x-dev
Status: Needs review » Reviewed & tested by the community

Marking as RTBC. The latest patch is against 1.x-dev, not 1.1.

aramboyajyan’s picture

aramboyajyan commented
Status: Reviewed & tested by the community » Fixed

Committed, will be up shortly.

Thanks everyone!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

hgoto’s picture

hgoto commented

This issue was solved in the dev version but there's no stable release yet after the commit. So I'd like to share the quick fix without the patch for future visitors.

You can remove the extra "Edit view" link by changing the Views view setting. The view is titled "Line items (Commerce Line Item)".

http://example.com/admin/structure/views/view/commerce_line_item_table/e...

Visit the setting page and open the "Advanced" section. And change the "Hide contextual links" to "Yes" and save the view. Then, you'll no longer see the contextual link for this.

aramboyajyan’s picture

aramboyajyan commented

I seem to be the only active maintainer at the moment but I don't have enough permissions for creating a new release. I already contacted the project owner and asked for those permissions; as soon as I get them, I will create a new release.

hgoto’s picture

hgoto commented

@aramboyajyan thank you very much for your reaction. I'm looking forward to seeing the new release.