Hi there,
started yesterday porting the 7.x-2.x version to drupal 8
here's the git repo https://github.com/iwanfux/simplenews/tree/8.x-1.x
best regards
ifux
Roadmap:
Convert settings formsNewsletter config entitySubscriber content entity (Including edit form but probably no views integration yet)Subscriptions as an extended entity reference between subscribers and newslettersRoughly at this point, start to port the pretty extensive test coverage that we have together with porting the functionalitySubscription blocks and pagesNewsletter issues (Extended entity reference to newsletters for nodes)Spool managementSending of newslettersPort mailing tests- Views integration (Including replacing the default subscriber and newsletter issue listings with views)
- Migrate path
- Displaying recent issues in subscription blocks
- Everything that I forgot and new features :)
| Comment | File | Size | Author |
|---|---|---|---|
| #25 | simplenews-2254957-porting-to-d8-todo-removed.patch | 799 bytes | Anushka-mp |
Comments
Comment #1
miro_dietikerAwesome to have you part of the team and getting started! We are always available for feedback.
Could you please update this post with a bit of status and strategy detail (next steps / short term goals) on a periodical basis?
The finally ultimate thing would be a roadmap with a timeline. ;-)
Comment #2
berdirYeah, we're going to make a contrib maintainer out of you ;)
Started a roadmap in the issue summary.
Comment #3
ifux commentedComment #4
ifux commentedComment #5
ifux commentedComment #6
ifux commentedFinished a big part of the test coverage (settings, subscriptions)
Ported subscription blocks and pages.
Comment #7
miro_dietikerThank you for the great progress recently and we are happy to have you join our sprints!
As discussed, we recently stumbled upon personalisation again and actually with every single project this topic came up. (And some strange hacks / custom modules where required since simplenews is not really made for it out of the box...) I do like to address this issue with our Drupal 8 release as early as possible.
Possibly missing above is a migrate path and in reference to the issue about the status of 7.x-2.x the question if we support it at all for migration or if we recommend to migrate from 7.x-1.x.
Comment #8
miro_dietikerAdded migrate path to summary ;-)
Comment #9
berdirWith migrations, it would certainly be easier to support both, but there's a lot of stuff that yet needs to be figured out. The default migration would automatically convert the taxonomy terms that we no longer need for example, but I guess you could delete them manually.
There are few reasons to do something special with the target, what we need to provide are sources for all variants that we want to support, process plugins and migration entities to tie it all together.
Comment #10
miro_dietikerWe have subscriber management working and we're pretty near to Beta.
It's time to have a 8.x branch in Simplenews and a dev release to make this progress visible for the d.o module search and overview pages.
As such i would not wait for the feature "sending newsletters" to complete to merge it in.
As a result, switching to a strict issue based patch + review workflow would be best for future improvements.
What do you think, when is the right time to switch?
Comment #11
berdirI think it's too early for that. IMHO doesn't make sense to do that before most of the existing tests are working again, I can review on github too. patch based processes are too slow for the current phase and testbot is broken anyway it seems.
Comment #12
miro_dietikerUnderstand. Please still reconsider before DrupalCon (Contrib Status) though. :-)
Comment #13
ifux commentedFinished porting the test coverage for settings and subscription
Created issues (extended entity reference) and started working on the mail spool stuff
Comment #14
miro_dietikerGreat progress.
As discussed today:
In Simplenews 7.x we have naming issues due to historic reasons. We thought this was corrected in 7.x-2.x but most importantly for 8.x, we should decide for a clean naming and strictly stick with it. Newsletter, Issue, ...
Also, i would love to have simplytest.me integration ASAP for demo purposes. We push this with all our modules to lower the barriers and people can learn about the module by example. :-)
Comment #15
ifux commentedthere is another issue we have to work on.
at the moment there is no real subscriber AND subscription overview
its a kind of a mix and we do not have for example an overview of unsubscribed subscribers
Comment #16
miro_dietikerAs discussed, we introduce the concept of a subscriber.
In order to manage subscribers, we have put subscriber management under people.
Similar to Configuration of "Account settings", there should be a "Subscriber settings". The subscriber field management should be there.
The Subscriber settings will then host settings that maintain the relationship between subscribers and users.
This leads to a pretty clean UI / consistent D8 core UX patterns.
Comment #17
ifux commentedPorted almost all tests (expect block testing)
Mails can now be send
spool management done
Comment #18
miro_dietikerSession about Simplenews port status prepared for DrupalCon, together with ifux.
I also requested collaboration with the more recent added newsletter module...
#2346641: Drupal 8 port
Would be great if we find a collaborative consensus for Drupal 8.
BTW: Arla implemented field sync between Subscriber and User.
We are looking forward to merge in full personalisation this week!
Also added an issue about simplytest.me demo data i do like to see:
#2346837: Support simplytest.me
Comment #19
ifux commentedfound something which did not directly port
just mentioned it, that we do not forget it :)
Comment #20
miro_dietikerI vote for merging this project in to d.o and start working issue queue based.
What do you think?
Comment #21
berdirPushed the current code to drupal.org, after some further cleanup. Commented out a handful of failing tests as drupal.org testing is only useful if the branch is green. Opened #2401019: Enable commented out tests in 8.x-1.x as a reminder to uncomment them again.
I would suggest to create follow-up issues for the remaining issues and then close this issue.
https://www.drupal.org/node/2401069
https://qa.drupal.org/pifr/test/937688 came back green!
Comment #22
berdirComment #23
miro_dietikerAwesome!
Will test it soon and start creating issues. :-)
Comment #24
miro_dietikerUnassigning ifux from this task.
Opening this task and all followups to other contributor from team and community.
Comment #25
Anushka-mp commentedIssues created as discussed. uploading a patch to remove todo.txt
Comment #27
berdirGreat. The only task here that did not have an issue yet was migration support, we created that as well.
Marking this as fixed, there is of course still a lot to do, but we will track further progress in separate issues.