CommentFileSizeAuthor
#7 testperf.search-SearchCommentCountToggleTest.patch2.87 KBsun
#3 testperf.search-SearchCommentCountToggleTest.patch2.87 KBsun
testperf.search-SearchCommentCountToggleTest.patch1.14 KBsun

Comments

Status: Needs review » Needs work

The last submitted patch, testperf.search-SearchCommentCountToggleTest.patch, failed testing.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented

This test is relying on (as written) the following from standard profile:
- Article content type

That might be enough to get it working?

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Needs work » Needs review
StatusFileSize
new testperf.search-SearchCommentCountToggleTest.patch2.87 KB

This test has a completely needless dependency on the search block, which is irrelevant for the test.

Attached patch should come back green.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented

Agreed, the test does not need to use the search block. These changes so far look fine to me, so assuming the test bot agrees, I am +1 for RTBC.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented

Actually, it would probably be better to do drupalGet('search/node') instead of just 'search'? 'search' ends up at 'search/node', but ...

sun’s picture

sun
Primary language German
Location Karlsruhe
commented

I don't think that's necessary right now — in case it changes in the future, then it's just a one line adjustment here.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
StatusFileSize
new testperf.search-SearchCommentCountToggleTest.patch2.87 KB

Changed to /search/node.

Let's move forward? The quicker we get these issues done, the sooner we'll see a true improvement in core test suite performance.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Status: Needs review » Reviewed & tested by the community

Thanks! Let's get this in, assuming bot agrees.

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.x, thanks!

  • Commit 3de5102 on 8.x by catch: 
    Issue #2254195 by sun: Fix test performance of Drupal\search\Tests\...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.