The 2026 Drupal Business Survey is open. Your response will help shape the future of the Drupal business ecosystem.| Comment | File | Size | Author |
|---|---|---|---|
| #7 | testperf.search-SearchCommentCountToggleTest.patch | 2.87 KB | sun |
| #3 | testperf.search-SearchCommentCountToggleTest.patch | 2.87 KB | sun |
| testperf.search-SearchCommentCountToggleTest.patch | 1.14 KB | sun |
Comments
Comment #2
jhodgdonThis test is relying on (as written) the following from standard profile:
- Article content type
That might be enough to get it working?
Comment #3
sunThis test has a completely needless dependency on the search block, which is irrelevant for the test.
Attached patch should come back green.
Comment #4
jhodgdonAgreed, the test does not need to use the search block. These changes so far look fine to me, so assuming the test bot agrees, I am +1 for RTBC.
Comment #5
jhodgdonActually, it would probably be better to do drupalGet('search/node') instead of just 'search'? 'search' ends up at 'search/node', but ...
Comment #6
sunI don't think that's necessary right now — in case it changes in the future, then it's just a one line adjustment here.
Comment #7
sunChanged to /search/node.
Let's move forward? The quicker we get these issues done, the sooner we'll see a true improvement in core test suite performance.
Comment #8
jhodgdonThanks! Let's get this in, assuming bot agrees.
Comment #9
catchCommitted/pushed to 8.x, thanks!