Problem/Motivation

Speed up testbot and simplify tests by using the testing profile instead of the standard profile.

Steps to reproduce

Proposed resolution

Convert Drupal\node\Tests\NodeAccessBaseTableTest to use the testing profile, not the standard profile.

Remaining tasks

Update patch
Review
Commit

User interface changes

N/A

API changes

N/A

Data model changes

N/A

Release notes snippet

N/A

CommentFileSizeAuthor
#29 2254187-29.patch2.48 KBsmustgrave
#29 interdiff-27-29.txt2.37 KBsmustgrave
#27 2254187-27.patch534 bytessmustgrave
#26 2254187-26.patch615 bytesandregp
#15 2254187-node-access-test-performance-15.patch2.31 KBnickdickinsonwilde
#11 2254187-node-access-test-performance-11.patch783 bytesnickdickinsonwilde
#3 fix_test_performance_of-2254187-3.patch1.15 KBmarkdorison
testperf.node-NodeAccessBaseTableTest.patch1.17 KBsun

Comments

Status: Needs review » Needs work

The last submitted patch, testperf.node-NodeAccessBaseTableTest.patch, failed testing.

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

markdorison’s picture

markdorison
he/him
commented
Version: 8.1.x-dev » 8.3.x-dev
Status: Needs work » Needs review
StatusFileSize
new fix_test_performance_of-2254187-3.patch1.15 KB

Patch no longer applies; re-rolled.

Status: Needs review » Needs work

The last submitted patch, 3: fix_test_performance_of-2254187-3.patch, failed testing.

dawehner’s picture

dawehner
Primary language German
commented 
+++ b/core/scripts/run-tests.sh
@@ -107,7 +107,7 @@
-$test_list = simpletest_script_get_test_list();
+$test_list = array_fill(0, 1, 'Drupal\node\Tests\NodeAccessBaseTableTest');

This should not be part of the final patch :)

@markdorison
For personal use you can use run-tests.sh \Drupal\foo\Tests\ExampleTest to run just a single test class.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.0-alpha1 will be released the week of January 30, 2017, which means new developments and disruptive changes should now be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.0-alpha1 will be released the week of July 31, 2017, which means new developments and disruptive changes should now be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.0-alpha1 will be released the week of January 17, 2018, which means new developments and disruptive changes should now be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

voleger’s picture

voleger
he/his
Primary language Ukrainian
Location Ukraine, Rivne
commented
Issue tags: +Needs reroll
nickdickinsonwilde’s picture

nickdickinsonwilde
He/Him/His
Primary language English
Location Victoria, BC (T'So-uke lands)
commented
Status: Needs work » Needs review
Issue tags: -Needs reroll
StatusFileSize
new 2254187-node-access-test-performance-11.patch783 bytes

rerolllllled

Status: Needs review » Needs work

The last submitted patch, 11: 2254187-node-access-test-performance-11.patch, failed testing. View results

nickdickinsonwilde’s picture

nickdickinsonwilde
He/Him/His
Primary language English
Location Victoria, BC (T'So-uke lands)
commented

ahem! that needs more than a reroll. May look at this later today, if I'm about to, I'll assign it to myself.

nickdickinsonwilde’s picture

nickdickinsonwilde
He/Him/His
Primary language English
Location Victoria, BC (T'So-uke lands)
commented
Assigned: Unassigned » nickdickinsonwilde
nickdickinsonwilde’s picture

nickdickinsonwilde
He/Him/His
Primary language English
Location Victoria, BC (T'So-uke lands)
commented
Assigned: nickdickinsonwilde » Unassigned
Status: Needs work » Needs review
StatusFileSize
new 2254187-node-access-test-performance-15.patch2.31 KB

Hmmph! Yeah that needed more changes to say the least.
Ready for review.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented

So this changes from the default install profile to minimal instead of standard and creats the voc/field instead.While this is probably correct, how much does this gain in performance?

nickdickinsonwilde’s picture

nickdickinsonwilde
He/Him/His
Primary language English
Location Victoria, BC (T'So-uke lands)
commented

No clue, but @dawehner tagged it as an cheap gain on slack so grabbed it.
My local system is *not* good for performance testing it really - Functional tests take 3+ minutes. I suppose you could also look at that as a good system because of how cruddy it is for perf tests, but boring to run tests that sloooowly

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

quietone’s picture

quietone commented
Issue summary: View changes
Parent issue: #1595028: Convert tests using Standard profile to use Testing profile instead » #3270566: [meta] Convert remaining tests using Standard profile to use Testing profile instead
Related issues: +#1595028: Convert tests using Standard profile to use Testing profile instead

Adding issue summary and re-parenting.

quietone’s picture

quietone commented
Version: 9.4.x-dev » 10.0.x-dev
Status: Needs review » Needs work
andregp’s picture

andregp commented
Status: Needs work » Needs review
StatusFileSize
new 2254187-26.patch615 bytes

I tried making a reroll of #15 and running the test locally, but I got errors like

1) Drupal\Tests\node\Functional\NodeAccessBaseTableTest::testNodeAccessBasic
Drupal\Core\Entity\EntityStorageException: 'taxonomy_vocabulary' entity with ID 'tags' already exists.

which made me suspect that the add-ons made on #15 to make the code work weren't necessary anymore. If there was a conflict it meant the code could already access filed_tags and it's dependencies, so I thought that maybe they didn't need to be configured locally on the tests. I then tried removing all extra code, ran the tests locally, and it passed! (Basically what I did was to use the suggestion from this issue's summary).

Here is the new patch.

smustgrave’s picture

smustgrave commented
StatusFileSize
new 2254187-27.patch534 bytes

Reading the description this appears to be updating the install profile.

#26 appears to be removing the theme.

Status: Needs review » Needs work

The last submitted patch, 27: 2254187-27.patch, failed testing. View results

smustgrave’s picture

smustgrave commented
Status: Needs work » Needs review
StatusFileSize
new interdiff-27-29.txt2.37 KB
new 2254187-29.patch2.48 KB
borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented
Status: Needs review » Reviewed & tested by the community

This looks great, the test is more specific and we have created more performance. Thanks @smustgrave

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Version: 10.0.x-dev » 9.5.x-dev
Status: Reviewed & tested by the community » Fixed

Backported to 9.5.x to keep the tests aligned.

Committed and pushed 999d5671ad to 10.1.x and 13ff52b3d9 to 10.0.x and 5f4f64dbfc to 9.5.x. Thanks!

  • alexpott committed 999d567 on 10.1.x 
    Issue #2254187 by smustgrave, NickDickinsonWilde, markdorison, andregp:...

  • alexpott committed 13ff52b on 10.0.x 
    Issue #2254187 by smustgrave, NickDickinsonWilde, markdorison, andregp:...

  • alexpott committed 5f4f64d on 9.5.x 
    Issue #2254187 by smustgrave, NickDickinsonWilde, markdorison, andregp:...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.