Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
Speed up testbot and simplify tests by using the testing profile instead of the standard profile.
Steps to reproduce
Proposed resolution
Convert Drupal\node\Tests\NodeAccessBaseTableTest to use the testing profile, not the standard profile.
Remaining tasks
Update patch
Review
Commit
User interface changes
N/A
API changes
N/A
Data model changes
N/A
Release notes snippet
N/A
Comment | File | Size | Author |
---|---|---|---|
#29 | 2254187-29.patch | 2.48 KB | smustgrave |
| |||
#29 | interdiff-27-29.txt | 2.37 KB | smustgrave |
Comments
Comment #3
markdorisonPatch no longer applies; re-rolled.
Comment #5
dawehnerThis should not be part of the final patch :)
@markdorison
For personal use you can use
run-tests.sh \Drupal\foo\Tests\ExampleTest
to run just a single test class.Comment #10
volegerComment #11
NickDickinsonWildererolllllled
Comment #13
NickDickinsonWildeahem! that needs more than a reroll. May look at this later today, if I'm about to, I'll assign it to myself.
Comment #14
NickDickinsonWildeComment #15
NickDickinsonWildeHmmph! Yeah that needed more changes to say the least.
Ready for review.
Comment #16
borisson_So this changes from the default install profile to minimal instead of standard and creats the voc/field instead.While this is probably correct, how much does this gain in performance?
Comment #17
NickDickinsonWildeNo clue, but @dawehner tagged it as an cheap gain on slack so grabbed it.
My local system is *not* good for performance testing it really - Functional tests take 3+ minutes. I suppose you could also look at that as a good system because of how cruddy it is for perf tests, but boring to run tests that sloooowly
Comment #24
quietone CreditAttribution: quietone at PreviousNext commentedAdding issue summary and re-parenting.
Comment #25
quietone CreditAttribution: quietone at PreviousNext commentedComment #26
andregp CreditAttribution: andregp at CI&T commentedI tried making a reroll of #15 and running the test locally, but I got errors like
which made me suspect that the add-ons made on #15 to make the code work weren't necessary anymore. If there was a conflict it meant the code could already access filed_tags and it's dependencies, so I thought that maybe they didn't need to be configured locally on the tests. I then tried removing all extra code, ran the tests locally, and it passed! (Basically what I did was to use the suggestion from this issue's summary).
Here is the new patch.
Comment #27
smustgrave CreditAttribution: smustgrave at Mobomo commentedReading the description this appears to be updating the install profile.
#26 appears to be removing the theme.
Comment #29
smustgrave CreditAttribution: smustgrave at Mobomo commentedComment #30
borisson_This looks great, the test is more specific and we have created more performance. Thanks @smustgrave
Comment #31
alexpottBackported to 9.5.x to keep the tests aligned.
Committed and pushed 999d5671ad to 10.1.x and 13ff52b3d9 to 10.0.x and 5f4f64dbfc to 9.5.x. Thanks!