Follow-up from #2100311: Allow filtering of modules by arbitrary search strings on the uninstall page.

We forgot to extend the label style from the modules page.

Label on modules page

Search label on uninstall page before patch #1

Search label on uninstall page after patch #1

Contributor tasks needed
Task Novice task? Contributor instructions Complete?
Manually test the patch Novice Instructions Yes
Embed before and after screenshots in the issue summary Novice Instructions Yes
Review patch to ensure that it fixes the issue, stays within scope, is properly documented, and follows coding standards Instructions Yes
CommentFileSizeAuthor
#10 modules_uninstall_label_after.png21.9 KBjonreid
#10 modules_uninstall_label_before.png21.38 KBjonreid
#10 modules_search_label_before.png13.21 KBjonreid
#6 2253917-after.png51.61 KBSpartyDan
#6 2253917-before.png70.93 KBSpartyDan
#1 drupal-uninstall_page_search_label_style-2253917-1.patch442 bytesyannickoo

Comments

yannickoo’s picture

yannickoo
Location Berlin
commented
Status: Active » Needs review
StatusFileSize
new drupal-uninstall_page_search_label_style-2253917-1.patch442 bytes
emma.maria’s picture

emma.maria
she/her
commented
Issue tags: +CSS, +frontend, +Novice
dcam’s picture

dcam commented
Issue summary: View changes

Updating in preparation for DrupalCon Austin sprints. See http://www.hook42.com/blog/prepping-drupalcon-austin-sprints-sprint-lead....

SpartyDan’s picture

SpartyDan commented

I am currently reviewing the patch and creating screenshots to add to the issue.

jonreid’s picture

jonreid commented

Looking at this also as a second review.

SpartyDan’s picture

SpartyDan commented
StatusFileSize
new 2253917-before.png70.93 KB
new 2253917-after.png51.61 KB
SpartyDan’s picture

SpartyDan commented
Issue summary: View changes
adanielyan’s picture

adanielyan commented
Assigned: Unassigned » adanielyan

I'm testing this patch.

SpartyDan’s picture

SpartyDan commented
Issue summary: View changes
StatusFileSize
new 2253917-before.png29.7 KB
new 2253917-after.png29.27 KB

Added before and after screenshots for issue

jonreid’s picture

jonreid commented
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new modules_search_label_before.png13.21 KB
new modules_uninstall_label_before.png21.38 KB
new modules_uninstall_label_after.png21.9 KB

Reviewed and validated.

The Uninstall Search label now has the same style as the Search label on the listing page. The CSS added is the same that is used for the listing label:

#system-modules label, #system-modules-uninstall label {
color: #1d1d1d;
font-size: 1.15em;
}

See attached screenshots for before images (List and Uninstall Search label) and after (Uninstall Search label).

adanielyan’s picture

adanielyan commented
Assigned: adanielyan » Unassigned
SpartyDan’s picture

SpartyDan commented
Issue summary: View changes

Edited issue summary.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 1: drupal-uninstall_page_search_label_style-2253917-1.patch, failed testing.

dcam’s picture

dcam commented
Status: Needs work » Reviewed & tested by the community

Unrelated test failure. Setting back to RTBC.

webchick queued 1: drupal-uninstall_page_search_label_style-2253917-1.patch for re-testing.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Nice catch.

Committed and pushed to 8.x. Thanks! Sorry for this sitting around so long.. my post-DrupalCon life got a bit hectic. :(

  • webchick committed c1ed4d6 on 8.x 
    Issue #2253917 by yannickoo: Use same style for Search label on...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.