Follow-up from #2100311: Allow filtering of modules by arbitrary search strings on the uninstall page.

We forgot to extend the label style from the modules page.

Label on modules page

Search label on uninstall page before patch #1

Search label on uninstall page after patch #1

Contributor tasks needed
Task Novice task? Contributor instructions Complete?
Manually test the patch Novice Instructions Yes
Embed before and after screenshots in the issue summary Novice Instructions Yes
Review patch to ensure that it fixes the issue, stays within scope, is properly documented, and follows coding standards Instructions Yes
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

yannickoo’s picture

Status: Active » Needs review
FileSize
442 bytes
emma.maria’s picture

Issue tags: +CSS, +frontend, +Novice
dcam’s picture

Issue summary: View changes

Updating in preparation for DrupalCon Austin sprints. See http://www.hook42.com/blog/prepping-drupalcon-austin-sprints-sprint-lead....

SpartyDan’s picture

I am currently reviewing the patch and creating screenshots to add to the issue.

jonreid’s picture

Looking at this also as a second review.

SpartyDan’s picture

FileSize
70.93 KB
51.61 KB
SpartyDan’s picture

Issue summary: View changes
adanielyan’s picture

Assigned: Unassigned » adanielyan

I'm testing this patch.

SpartyDan’s picture

Issue summary: View changes
FileSize
29.7 KB
29.27 KB

Added before and after screenshots for issue

jonreid’s picture

Issue summary: View changes
Status: Needs review » Reviewed & tested by the community
FileSize
13.21 KB
21.38 KB
21.9 KB

Reviewed and validated.

The Uninstall Search label now has the same style as the Search label on the listing page. The CSS added is the same that is used for the listing label:

#system-modules label, #system-modules-uninstall label {
color: #1d1d1d;
font-size: 1.15em;
}

See attached screenshots for before images (List and Uninstall Search label) and after (Uninstall Search label).

adanielyan’s picture

Assigned: adanielyan » Unassigned
SpartyDan’s picture

Issue summary: View changes

Edited issue summary.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 1: drupal-uninstall_page_search_label_style-2253917-1.patch, failed testing.

dcam’s picture

Status: Needs work » Reviewed & tested by the community

Unrelated test failure. Setting back to RTBC.

webchick’s picture

Status: Reviewed & tested by the community » Fixed

Nice catch.

Committed and pushed to 8.x. Thanks! Sorry for this sitting around so long.. my post-DrupalCon life got a bit hectic. :(

  • webchick committed c1ed4d6 on 8.x
    Issue #2253917 by yannickoo: Use same style for Search label on...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.