Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Follow-up from #2100311: Allow filtering of modules by arbitrary search strings on the uninstall page.
We forgot to extend the label style from the modules page.
Label on modules page
Search label on uninstall page before patch #1
Search label on uninstall page after patch #1
Task | Novice task? | Contributor instructions | Complete? |
---|---|---|---|
Manually test the patch | Novice | Instructions | Yes |
Embed before and after screenshots in the issue summary | Novice | Instructions | Yes |
Review patch to ensure that it fixes the issue, stays within scope, is properly documented, and follows coding standards | Instructions | Yes |
Comment | File | Size | Author |
---|---|---|---|
#10 | modules_uninstall_label_after.png | 21.9 KB | jonreid |
#10 | modules_uninstall_label_before.png | 21.38 KB | jonreid |
#10 | modules_search_label_before.png | 13.21 KB | jonreid |
#1 | drupal-uninstall_page_search_label_style-2253917-1.patch | 442 bytes | yannickoo |
Comments
Comment #1
yannickooComment #2
emma.mariaComment #3
dcam CreditAttribution: dcam commentedUpdating in preparation for DrupalCon Austin sprints. See http://www.hook42.com/blog/prepping-drupalcon-austin-sprints-sprint-lead....
Comment #4
SpartyDan CreditAttribution: SpartyDan commentedI am currently reviewing the patch and creating screenshots to add to the issue.
Comment #5
jonreid CreditAttribution: jonreid commentedLooking at this also as a second review.
Comment #6
SpartyDan CreditAttribution: SpartyDan commentedComment #7
SpartyDan CreditAttribution: SpartyDan commentedComment #8
adanielyan CreditAttribution: adanielyan commentedI'm testing this patch.
Comment #9
SpartyDan CreditAttribution: SpartyDan commentedAdded before and after screenshots for issue
Comment #10
jonreid CreditAttribution: jonreid commentedReviewed and validated.
The Uninstall Search label now has the same style as the Search label on the listing page. The CSS added is the same that is used for the listing label:
See attached screenshots for before images (List and Uninstall Search label) and after (Uninstall Search label).
Comment #11
adanielyan CreditAttribution: adanielyan commentedComment #12
SpartyDan CreditAttribution: SpartyDan commentedEdited issue summary.
Comment #14
dcam CreditAttribution: dcam commentedUnrelated test failure. Setting back to RTBC.
Comment #16
webchickNice catch.
Committed and pushed to 8.x. Thanks! Sorry for this sitting around so long.. my post-DrupalCon life got a bit hectic. :(