Problem/Motivation

Currently we have function test which checks for certain label in tree/form/raw/list pages. However they don't give enough coverage or confidence to add more functionality or fix bugs.

Proposed resolution

1. Add more unit tests for controller & manager
2. Introduce a config tests which has config with all type of elements and make sure they are displayed in all types of views.

Remaining tasks

User interface changes

N/A

API changes

N/A

CommentFileSizeAuthor
#14 2253749-14.patch1.13 KBvuil
#11 2253749-11.patch1.75 KBvuil

Comments

  • ilchovuchkov committed 23fec9d on 8.x-1.x 
    Issue #2253749 by ilchovuchkov: Add controller test.
vuil’s picture

vuil
Location Bulgaria 🇧🇬 🇪🇺 🌍
commented
Status: Active » Reviewed & tested by the community
vuil’s picture

vuil
Location Bulgaria 🇧🇬 🇪🇺 🌍
commented
Status: Reviewed & tested by the community » Fixed
idebr’s picture

idebr commented
Status: Fixed » Needs work

This test will not run:

  1. It is in the wrong namespace.
  2. It does not have a @group annotation.
  3. The classname does not match the filename.
vuil’s picture

vuil
Location Bulgaria 🇧🇬 🇪🇺 🌍
commented
Status: Needs work » Active

  • ilchovuchkov committed 4de3256 on 8.x-1.x 
    Issue #2253749 by ilchovuchkov: Update test  for all route controllers.
vuil’s picture

vuil
Location Bulgaria 🇧🇬 🇪🇺 🌍
commented
Status: Active » Fixed

Thank you!

Some of the 1st point is done!

idebr’s picture

idebr commented
Status: Fixed » Needs work

Some more work needed:

  1. The class is in the PHPUnit namespace, but implements a deprecated \Drupal\simpletest\WebTestBase
  2. The class does not actually test anything as described in the issue summary.

May I suggest you post a patch file instead? Reopening the issue when it is not fixed at all seems counterproductive.

vuil’s picture

vuil
Location Bulgaria 🇧🇬 🇪🇺 🌍
commented
Status: Needs work » Active

  • ilchovuchkov committed d81956e on 8.x-1.x 
    Issue #2253749 by ilchovuchkov: Replace deprecated WebTestBase with...
vuil’s picture

vuil
Location Bulgaria 🇧🇬 🇪🇺 🌍
commented
StatusFileSize
new 2253749-11.patch1.75 KB

  • ilchovuchkov committed 26f96c8 on 8.x-1.x 
    Issue #2253749 by ilchovuchkov: Update browser tests.
vuil’s picture

vuil
Location Bulgaria 🇧🇬 🇪🇺 🌍
commented
vuil’s picture

vuil
Location Bulgaria 🇧🇬 🇪🇺 🌍
commented
StatusFileSize
new 2253749-14.patch1.13 KB

Add a separate functional (browser) test.

vuil’s picture

vuil
Location Bulgaria 🇧🇬 🇪🇺 🌍
commented
Status: Active » Needs review

  • ilchovuchkov committed b1297c4 on 8.x-1.x 
    Issue #2253749 by ilchovuchkov: Add a separate functional (browser) test...
vuil’s picture

vuil
Location Bulgaria 🇧🇬 🇪🇺 🌍
commented
Related issues: +#2684383: Allow download of configuration files

Some of the tests issues have been fixed at the following feature issue: #2684383: Allow download of configuration files.

vuil’s picture

vuil
Location Bulgaria 🇧🇬 🇪🇺 🌍
commented
Status: Needs review » Postponed
vuil’s picture

vuil
Location Bulgaria 🇧🇬 🇪🇺 🌍
commented
Status: Postponed » Active
vuil’s picture

vuil
Location Bulgaria 🇧🇬 🇪🇺 🌍
commented
Status: Active » Fixed

I close the issue as Fixed (resolved, 3 years ago).

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.