It would be nice if we have theme_mark use bootstrap labels, I know it is minor issue but it would be nice when using bootstrap theme as admin theme.

CommentFileSizeAuthor
#1 theme_mark-2253473-1.patch1.03 KBmkhamash

Comments

mkhamash’s picture

mkhamash commented
Status: Active » Needs review
StatusFileSize
new theme_mark-2253473-1.patch1.03 KB
markhalliwell’s picture

markhalliwell
Primary language English
commented

This is fantastic, thanks for the patch @mkhamash! My only concern is that we'll get fallback for not making it configurable. Granted it's a simple sub-theme override if they want to change the classes, but it would also probably be good to provide an easier configuration via settings. What do you think?

mkhamash’s picture

mkhamash commented

I think it is very specific theme function that most people wouldn't even know it exists, also providing an option in the UI for a trivial functionality like this will confuse people and clutter the settings form, I can make Helper function for labels like _bootstrap_colorize_button if you think it is a good idea.

markhalliwell’s picture

markhalliwell
Primary language English
commented

I was thinking more from a color pallet perspective really. Not all sub-theme will want to use primary and info (as it might clash). Just thinking ahead is all.

  • Mark Carver committed 2723434 on 7.x-3.x authored by mkhamash 
    Issue #2253473 by mkhamash: Added Override theme_mark to use bootstrap...
markhalliwell’s picture

markhalliwell
Primary language English
commented
Component: Code » Templates
Assigned: mkhamash » Unassigned
Priority: Minor » Normal
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.