Objective

  1. rebuildContainer() only exists to synchronize the container of a child site with the parent site/test runner.

  2. It is meaningless and wrong to call rebuildContainer() in a test that does not extend from WebTestBase.

Proposed solution

  1. Move TestBase::rebuildContainer() into WebTestBase::rebuildContainer().

CommentFileSizeAuthor
#3 interdiff.txt1.94 KBsun
#3 test.rebuildcontainer.3.patch7.47 KBsun
#1 test.rebuildcontainer.1.patch5.54 KBsun

Comments

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Active » Needs review
StatusFileSize
new test.rebuildcontainer.1.patch5.54 KB

Status: Needs review » Needs work

The last submitted patch, 1: test.rebuildcontainer.1.patch, failed testing.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Needs work » Needs review
StatusFileSize
new test.rebuildcontainer.3.patch7.47 KB
new interdiff.txt1.94 KB

That's exactly the 2 test failures that I expected :-)

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Related issues: +#1878512: Clean up Simpletest's kernel/container preparation/rebuild logic now that the kernel is responsive to module enabling
sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Parent issue: » #2171683: Remove all Simpletest overrides and rely on native multi-site functionality instead
sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Title: Limit rebuildContainer() to web tests (WebTestBase) » rebuildContainer() is not limited to web tests (WebTestBase)
Category: Task » Bug report
Priority: Normal » Major

This is an architectural bug, as is the sister issue #2253067: settingsSet() is not limited to KernelTestBase

ParisLiakos’s picture

ParisLiakos commented
Status: Needs review » Reviewed & tested by the community

makes complete sense to me

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.x, thanks!

  • Commit bd248aa on 8.x by catch: 
    Issue #2252967 by sun: RebuildContainer() is not limited to web tests (...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.