CommentFileSizeAuthor
#10 issue-2252095.patch2.37 KBlsolesen
#1 issue-2252095.patch2.17 KBlsolesen

Comments

lsolesen’s picture

lsolesen commented
Status: Active » Needs review
StatusFileSize
new issue-2252095.patch2.17 KB

  • Commit bed8617 on 7.x-1.x authored by lsolesen, committed by dsnopek: 
    Issue #2252095: Add test for one time login.
dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented
Status: Needs review » Fixed

Thanks, @lsolesen!

I had to add an additional step to get it to work for me:

When I press the "Log in" button

This has been committed. :-)

lsolesen’s picture

lsolesen commented

Strange. In my tests it did not show that page, even though I expected it to. Maybe there should be some tests on what should be on the page with the button?

But cool that it works :)

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented
Status: Fixed » Active

Hrm, for some reason it is failing on Travis-CI but passing for me locally. :-/ Maybe something on Travis-CI is causing it to skip that page?

https://travis-ci.org/panopoly/panopoly/jobs/23927163#L764

I'm going to revert it for now, until I have time to investigate...

  • Commit 8d0a0d0 on 7.x-1.x by dsnopek: 
    Revert "Issue #2252095: Add test for one time login."

This reverts...
lsolesen’s picture

lsolesen commented

For me locally it also skips that page?

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented

Hrm.. Do you have any idea why? Because that page *should* be shown if you're not already logged in.

lsolesen’s picture

lsolesen commented
Status: Active » Needs work
lsolesen’s picture

lsolesen commented
Status: Needs work » Needs review
StatusFileSize
new issue-2252095.patch2.37 KB
dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented

For a little context: @lsolesen and @mglaman worked out via IRC that this was due to differences in Drush versions, and @lsolesen's patch in #10 is meant to allow this to work with any version. Thanks again, guys!

I just tested it locally, and everything worked! Let's see if Travis-CI likes it:

https://travis-ci.org/panopoly/panopoly/builds/23954940

  • Commit a069261 on 7.x-1.x authored by lsolesen, committed by dsnopek: 
    Issue #2252095: Add test for one time login.
dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented
Status: Needs review » Fixed

Got a couple of passing jobs on Travis-CI - it worked!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.