As user, I would like to see bundle's label instead of machine name while editing the field (fape_field_edit_page() callback).

I would consider this as a bug as I don't see any use cases for using bundle's machine name in the title. It's likely that the $bundle variable was decided to be used while machine name and label was same while testing this implementation and wasn't paid attention?

Title related issue (but not related to this problem): #1346408: Use a title callback instead of drupal_set_title()

CommentFileSizeAuthor
#1 fape-2252029-1.patch992 bytesimiksu

Comments

imiksu’s picture

imiksu
Location Finland
commented
Assigned: imiksu » Unassigned
Status: Active » Needs review
StatusFileSize
new fape-2252029-1.patch992 bytes

I've tried this solving it right away under the callback function and using the information from $entity_info.

I'm assuming that any entity has an list of bundles, but I don't trust that all bundles has an label, so that's why I'm setting a default $bundle_label using the original $bundle value before the loop.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Parent issue: » #2050659: META: Plan for FAPE 7.x-1.2 release
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs review » Fixed

Committed. Thanks!

  • Commit 19496ef on 7.x-1.x authored by iMiksu, committed by DamienMcKenna: 
    Issue #2252029 by iMiksu: Use the entity bundle's label in the page...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.