Line 190 of commerce_cart.module:

return variable_get('commerce_order_apply_pricing_rules_link', TRUE) && commerce_order_access('update', 3);

Hardcoded order number of 3. Certainly you mean to be passing $order right?
Not familiar enough with the intention here to make the change, but thought I'd mention.

CommentFileSizeAuthor
#1 order_update_access_2251957.patch632 bytesa.milkovsky

Comments

a.milkovsky’s picture

a.milkovsky
he/him
Location UTC +2
commented
Status: Active » Needs review
StatusFileSize
new order_update_access_2251957.patch632 bytes

Issue is similar to Wrong order parameter passed to commerce_order_access function.
This bug was causing

"Notice: Trying to get property of non-object in commerce_entity_access() (line 1040 of /home/milkovsky/projects/itranspond/www/sites/all/modules/contrib/commerce/commerce.module)."

Fixed that. See my patch.

rszrama’s picture

rszrama commented
Title: Hardcoded order number in commerce_cart_order_refresh_form_access() » Incorrect parameter in call to commerce_cart_order_refresh_form_access()
Status: Needs review » Fixed

It's just a copy / paste error from where the integer 3 used to refer to a path based argument in a menu item's info array. Good catch!

  • Commit 40751b9 on 7.x-1.x authored by a.milkovsky, committed by rszrama: 
    Issue #2251957 by a.milkovsky: fix a typo in an order access argument.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.