CommentFileSizeAuthor
#5 interdiff.txt1015 bytesultimike
#5 2249149-5.patch3.31 KBultimike
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 73,039 pass(es). View
#1 2249149-1.patch3.14 KBbenjy
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 72,920 pass(es). View
Members fund testing for the Drupal project. Drupal Association Learn more

Comments

benjy’s picture

Issue summary: View changes
Status: Active » Needs review
FileSize
3.14 KB
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 72,920 pass(es). View

System logging migration to port the error_level variable into config.

dawehner’s picture

Kudos for PI as patch size!

ultimike’s picture

Status: Needs review » Reviewed & tested by the community

Looks good to me. Very straight-forward and nothing complicated here.

-mike

alexpott’s picture

Status: Reviewed & tested by the community » Needs work
+++ b/core/modules/migrate_drupal/src/Tests/d6/MigrateSystemLoggingTest.php
@@ -0,0 +1,51 @@
+  public function testSystemLogging() {
+    $config = \Drupal::config('system.logging');
+    $this->assertIdentical($config->get('error_level'), 'some');
+  }

We can now assert the config schema is correct. See #2293419: Add config schema test to all configuration test in migration, fix bugs

ultimike’s picture

Status: Needs work » Needs review
FileSize
3.31 KB
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 73,039 pass(es). View
1015 bytes

assertConfigSchema test added.

Thanks,
-mike

benjy’s picture

Status: Needs review » Reviewed & tested by the community

Good catch, fix looks good.

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed 421123a and pushed to 8.x. Thanks!

  • alexpott committed 421123a on 8.x
    Issue #2249149 by ultimike, benjy | chx: Create a system_logging...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.