On a theme's settings page there is a toggle for "User verification status in comments", but this is inaccurate as it's not entirely restricted to comments. For example you could allow anonymous users to create nodes of a certain type, and if you display authoring information for that content type it will still say "Anonymous (not verified)". To make matters worse, if the comment module is not enabled you cannot uncheck the toggle.

We should either rename the setting and remove the module_exists() check around it, or split it up like user pictures, which has "User pictures in posts" and "User pictures in comments".

Files: 
CommentFileSizeAuthor
#10 core-user-themehandler-2249077-2.patch2.82 KBarchunan
FAILED: [[SimpleTest]]: [PHP 5.5 MySQL] 22,730 pass(es), 999 fail(s), and 999 exception(s). View
#7 core-user-themehandler-2249077-2.patch4.57 KBarchunan
FAILED: [[SimpleTest]]: [PHP 5.5 MySQL] 14,395 pass(es), 998 fail(s), and 998 exception(s). View

Comments

Cottser’s picture

+1, I agree. From template_preprocess_username():

  $variables['extra'] = '';
  $variables['uid'] = $account->id();
  if (empty($variables['uid'])) {
    if (theme_get_setting('features.comment_user_verification')) {
      $variables['extra'] = ' (' . t('not verified') . ')';
    }
  }
archunan’s picture

Assigned: Unassigned » archunan
archunan’s picture

Status: Active » Needs review
FileSize
1.94 KB
FAILED: [[SimpleTest]]: [PHP 5.5 MySQL] Unable to apply patch 2421005-hasContainer-1_0.patch. Unable to apply patch. See the log in the details link for more information. View

We have renamed the setting for User Verification status as generic for node and comments (not specific to comments alone) and removed the module_exists() check and it will be available always. For Anonymous users whenever we are disabling "User verification status in comments" "not verified" text wont display and if we enable it will shows up. Please review and let us know.

Credit shared by Sateesh to address this issue.

Status: Needs review » Needs work

The last submitted patch, 3: 2421005-hasContainer-1.patch, failed testing.

Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 3: 2421005-hasContainer-1.patch, failed testing.

archunan’s picture

Status: Needs work » Needs review
FileSize
4.57 KB
FAILED: [[SimpleTest]]: [PHP 5.5 MySQL] 14,395 pass(es), 998 fail(s), and 998 exception(s). View

Hi

Sorry for the wrong patch file upload.Uploaded right one now.Can you review and provide feedback

archunan’s picture

Status: Needs review » Needs work

The last submitted patch, 7: core-user-themehandler-2249077-2.patch, failed testing.

archunan’s picture

Status: Needs work » Needs review
FileSize
2.82 KB
FAILED: [[SimpleTest]]: [PHP 5.5 MySQL] 22,730 pass(es), 999 fail(s), and 999 exception(s). View

Status: Needs review » Needs work

The last submitted patch, 10: core-user-themehandler-2249077-2.patch, failed testing.

joelpittet’s picture

Version: 8.0.x-dev » 8.1.x-dev
Assigned: archunan » Unassigned
Status: Needs work » Needs review

Maybe tricky to change now that we are in RC, but maybe we can fix this in 8.1.x?

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.0-beta1 was released on March 2, 2016, which means new developments and disruptive changes should now be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.0-beta1 was released on August 3, 2016, which means new developments and disruptive changes should now be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.0-alpha1 will be released the week of January 30, 2017, which means new developments and disruptive changes should now be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.