On a theme's settings page there is a toggle for "User verification status in comments", but this is inaccurate as it's not entirely restricted to comments. For example you could allow anonymous users to create nodes of a certain type, and if you display authoring information for that content type it will still say "Anonymous (not verified)". To make matters worse, if the comment module is not enabled you cannot uncheck the toggle.

We should either rename the setting and remove the module_exists() check around it, or split it up like user pictures, which has "User pictures in posts" and "User pictures in comments".

CommentFileSizeAuthor
#30 interdiff_2249077_25-30.txt414 bytesankithashetty
#30 2249077-30.patch2.24 KBankithashetty
#25 2249077-25.patch2.36 KBadityasingh
#20 2249077-11.patch2.77 KBaleevas
#10 core-user-themehandler-2249077-2.patch2.82 KBarchunan
#7 core-user-themehandler-2249077-2.patch4.57 KBarchunan
#3 2421005-hasContainer-1.patch1.94 KBarchunan

Comments

star-szr’s picture

star-szr
he/him
Primary language English
commented
Issue tags: +Twig, +consistency, +theme system cleanup

+1, I agree. From template_preprocess_username():

  $variables['extra'] = '';
  $variables['uid'] = $account->id();
  if (empty($variables['uid'])) {
    if (theme_get_setting('features.comment_user_verification')) {
      $variables['extra'] = ' (' . t('not verified') . ')';
    }
  }
archunan’s picture

archunan commented
Assigned: Unassigned » archunan
archunan’s picture

archunan commented
Status: Active » Needs review
StatusFileSize
new 2421005-hasContainer-1.patch1.94 KB

We have renamed the setting for User Verification status as generic for node and comments (not specific to comments alone) and removed the module_exists() check and it will be available always. For Anonymous users whenever we are disabling "User verification status in comments" "not verified" text wont display and if we enable it will shows up. Please review and let us know.

Credit shared by Sateesh to address this issue.

Status: Needs review » Needs work

The last submitted patch, 3: 2421005-hasContainer-1.patch, failed testing.

Status: Needs work » Needs review

archunan queued 3: 2421005-hasContainer-1.patch for re-testing.

Status: Needs review » Needs work

The last submitted patch, 3: 2421005-hasContainer-1.patch, failed testing.

archunan’s picture

archunan commented
Status: Needs work » Needs review
StatusFileSize
new core-user-themehandler-2249077-2.patch4.57 KB

Hi

Sorry for the wrong patch file upload.Uploaded right one now.Can you review and provide feedback

archunan’s picture

archunan commented

Status: Needs review » Needs work

The last submitted patch, 7: core-user-themehandler-2249077-2.patch, failed testing.

archunan’s picture

archunan commented
Status: Needs work » Needs review
StatusFileSize
new core-user-themehandler-2249077-2.patch2.82 KB

Status: Needs review » Needs work

The last submitted patch, 10: core-user-themehandler-2249077-2.patch, failed testing.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Version: 8.0.x-dev » 8.1.x-dev
Assigned: archunan » Unassigned
Status: Needs work » Needs review

Maybe tricky to change now that we are in RC, but maybe we can fix this in 8.1.x?

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.0-beta1 was released on March 2, 2016, which means new developments and disruptive changes should now be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.0-beta1 was released on August 3, 2016, which means new developments and disruptive changes should now be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.0-alpha1 will be released the week of January 30, 2017, which means new developments and disruptive changes should now be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.0-alpha1 will be released the week of July 31, 2017, which means new developments and disruptive changes should now be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.0-alpha1 will be released the week of January 17, 2018, which means new developments and disruptive changes should now be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

markhalliwell’s picture

markhalliwell
Primary language English
commented
Status: Needs review » Needs work
Issue tags: +Needs reroll

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

aleevas’s picture

aleevas
he/him
Primary language Russian
commented
Issue tags: -Needs reroll
StatusFileSize
new 2249077-11.patch2.77 KB

The patch from the comment#10 was rerolled successfully

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

adityasingh’s picture

adityasingh commented
Status: Needs work » Needs review
StatusFileSize
new 2249077-25.patch2.36 KB

Reroll the patch for 9.2.x.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

mstrelan’s picture

mstrelan commented 
+++ b/core/modules/system/src/Form/ThemeSettingsForm.php
@@ -173,10 +173,6 @@ public function buildForm(array $form, FormStateInterface $form_state, $theme =
-    if (!$this->moduleHandler->moduleExists('comment')) {
-      $disabled['toggle_comment_user_picture'] = TRUE;
-      $disabled['toggle_comment_user_verification'] = TRUE;
-    }

We should either leave toggle_comment_user_picture inside the moduleExists() condition or rename it as we're doing for user verification.

mstrelan’s picture

mstrelan commented
Status: Needs review » Needs work
ankithashetty’s picture

ankithashetty
Location Karnataka, India
commented
Status: Needs work » Needs review
StatusFileSize
new 2249077-30.patch2.24 KB
new interdiff_2249077_25-30.txt414 bytes

Updated patch in #25 addressing the changes suggested in #28, thanks!

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs review » Needs work 
+++ b/core/config/schema/core.data_types.schema.yml
@@ -179,9 +179,9 @@ theme_settings:
-        comment_user_verification:
+        user_verification_status:

We can't just rename a schema key, we have to provide an upgrade path for users who might already have this setting enabled.

A large number of the tests failed as well because not all instances of comment_user_verification have been changed.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Issue tags: +Needs upgrade path
mstrelan’s picture

mstrelan commented

I'm not really sure that this should even be a theme setting. It would probably make more sense in user.settings.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.