After editing node in Drupal core's Overlay using Bootstrap theme (latest dev for D7), following error is displayed twice:

Warning: Invalid argument supplied for foreach() in element_children() (line 6420 of /var/www/pasporty/includes/common.inc)

The error doesn't appear when using other themes, such as Shiny. Error also doesn't appear to be related to https://drupal.org/node/1711256, as I'm not using Advanced Help module.

CommentFileSizeAuthor
#1 element_children-null-value-2247933-1.patch1.09 KBmkhamash

Comments

mkhamash’s picture

mkhamash commented
Status: Active » Needs work
StatusFileSize
new element_children-null-value-2247933-1.patch1.09 KB

I have been able to reproduce the problem with media browser modal box, I think media browser is filling the region with null to prevent any region from being print, that what I think I didn't go over media code, but I think it is an acceptable behavior and a lot of modules will use.

I have provided a patch that could prevent the problem, but I am not sure if we would like to do it this way.

milos.kroulik’s picture

milos.kroulik commented
Status: Needs work » Needs review

Thanks a lot, your patch seems to be working fine for me. Perhaps we should have other reviews before RTBCing it.

markhalliwell’s picture

markhalliwell
Primary language English
commented
Version: 7.x-3.x-dev » 8.x-3.x-dev
Issue tags: +needs backport to 7.x-3.x

This should get fixed upstream first and then backported.

mkhamash’s picture

mkhamash commented
Assigned: Unassigned » mkhamash
Status: Needs review » Needs work

I will try to work on that this weekend.

  • Commit 179d90f on 7.x-3.x authored by mkhamash, committed by Mark Carver: 
    Issue #2247933 by mkhamash | milos.kroulik: "Warning: Invalid argument...
markhalliwell’s picture

markhalliwell
Primary language English
commented
Issue tags: -needs backport to 7.x-3.x

Went ahead and committed this to 7.x.

markhalliwell’s picture

markhalliwell
Primary language English
commented
Version: 8.x-3.x-dev » 7.x-3.x-dev
Assigned: mkhamash » Unassigned
Status: Needs work » Closed (fixed)

I'm just moving this back to 7.x. If there needs to be any re-evaluation for 8.x, create a new issue.