Reviewed & tested by the community
Project:
Webform Features
Version:
7.x-4.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
23 Apr 2014 at 13:12 UTC
Updated:
16 Jul 2020 at 00:08 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
bmeme commentedI don't know if it is the same context, and the issue is also quite old, BUT:
I have the same error in my drupal instance with:
* Webform 7.x-4.2+16-dev
* Webform Features 7.x-3.0-beta3+2-dev
* Webform Term Opts 7.x-4.0
* Options element 7.x-1.12
* Form Builder / Form Builder Webform UI 7.x-1.7
The patch is quite simple to apply: in "webform_features_webform_component_insert()" function, the db_update use $component['machine_name'] as field, but this does not exist. You have to use $component['form_key'].
Attached you'll find my patch. Bye!
Comment #2
bmeme commentedSorry use this patch... :)
Comment #3
duaelfr@bmeme That module is NOT compatible with webform 4.x, sorry.
I wish I had more time to maintain it...
The fact is that your components might already have a machine_name because it should be created on module install if components already exists or during the component creation. If they don't have one, that's an other issue that we'll have to fix.
Comment #4
kyletaylored commentedWe're using Webform 3.x. This happens when we try to create a NEW Webform and upon hitting "Publish", this is the error we get.
Patch in #2 definitely works for us.
Comment #5
sdstyles commentedI use webform_layout and webform 7.x-4.10 with webform_features 7.x-3.0-beta3 and I have this error:
Notice: Undefined index: machine_name in webform_features_webform_component_insert() when I use a component from webform_layout module.
Above patch #2 solved the issue, but I was forced to re-roll it to apply it with git.
Comment #6
socialnicheguru commentedThe patch definitely works and is needed.
this worked for webform 7.4
Comment #7
goldJust wanting to bump this.
I've just spent a few hours tracking a clients bug to this issue. The patch here at #5 is working for me also. Any chance we can get this merged in?
Comment #8
miteshmapSure @Gold, I'll try to merge it ASAP.
Comment #10
miteshmapComment #12
nikolabintev commentedHere is a patch that could be applied against 7.x-4.x dev version.
Comment #13
nikolabintev commentedComment #14
varshith commented@miteshmap
Can you pls reopen this issue as this issue is still there for 7.x-4.x?
The patch above works for 7.x-4.x-dev
Comment #15
miteshmapComment #16
rosk0Looks good. Should be committed.
Also it would be awesome to release new version with this as there is some unreleased stuff in 7.x-4.x: #2722991: PHP Notice: Undefined index: email in webform_features_export_render(), #2688039: Introduce a way to alter webform on export/import and bug fix without the issue on DO https://git.drupalcode.org/project/webform_features/-/commit/bc40b5f62c7... .