I want to override certain node internal URLs using the 'uri callback' ability of entity_uri() and hook_entity_info(). Right now uc_product hard-codes the links to products as node/nid. It should not and use entity_uri() instead.

CommentFileSizeAuthor
#5 order-uri-fixes.patch5.84 KBlongwave
#4 node-uri-fixes.patch9.67 KBlongwave
uc-product-uc-cart-url.patch896 bytesDave Reid
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

longwave’s picture

longwave
he/him
Primary language English
Location UK
CreditAttribution: longwave commented
Version: 7.x-3.x-dev » 8.x-4.x-dev
Status: Needs review » Patch (to be ported)

Committed to 7.x-3.x, thanks! Needs porting to 8.x-4.x, there's also a few other places we assume node/$nid which could be replaced.

  • Commit 2d999e2 on 7.x-3.x authored by Dave Reid, committed by longwave: 
    Issue #2246817 by Dave Reid: Cart products should use entity_uri().
TR’s picture

TR CreditAttribution: TR commented

Bump.

longwave’s picture

longwave
he/him
Primary language English
Location UK
CreditAttribution: longwave commented
Status: Patch (to be ported) » Needs review
FileSize
node-uri-fixes.patch9.67 KB

The original issue doesn't seem to be a problem any more, but there are some simpler methods we can use instead of calling Url::fromRoute() and Link::createFromRoute() when we have an entity object available.

longwave’s picture

longwave
he/him
Primary language English
Location UK
CreditAttribution: longwave commented
FileSize
order-uri-fixes.patch5.84 KB

Orders can be similarly simplified.

  • longwave committed 67cb1b7 on 8.x-4.x 
    Issue #2246817 by longwave: Simplify order link and URI generation.
  • longwave committed 739f7b9 on 8.x-4.x
    Issue #2246817 by longwave: Simplify node link and URI generation.
longwave’s picture

longwave
he/him
Primary language English
Location UK
CreditAttribution: longwave commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.