Since updating from 4.x-beta1 to 4.x-dev, when I submit a webform that has a "Custom URL" for the redirect, instead of getting redirected to a url that looks like this:

mysite.com/target-page

the url has an extra unnecessary slash in it like this:

mysite.com//target-page

CommentFileSizeAuthor
#3 webform_leading_slash_redirect-2246597.patch483 bytesquicksketch

Comments

quicksketch’s picture

quicksketch
he/him
commented

Could you provide an example of the URL you're entering into the Custom URL redirect? Is it a full URL or just a relative path?

nodecode’s picture

nodecode commented

Relative like this: target-page

quicksketch’s picture

quicksketch
he/him
commented
Status: Active » Fixed
StatusFileSize
new webform_leading_slash_redirect-2246597.patch483 bytes

Thanks, on my localhost I had been working with clean URLs turned off, so I wasn't seeing this problem. This was a side-effect of the better token supported added in #1244072: Use of tokens in external URL redirect locations not allowed in some cases and not URL Encoded. This patch corrects the problem, always returning an absolute URL, which then gets trimmed down to convert it to a relative URL in webform_client_form_submit().

  • Commit 2e0f9d9 on 7.x-4.x by quicksketch: 
    Issue #2246597 by quicksketch: Extra slash being added to Custom URL...
fenstrat’s picture

fenstrat
he/him
Primary language English
Location Australia
commented
Version: 7.x-4.x-dev » 8.x-4.x-dev
Assigned: Unassigned » fenstrat
Status: Fixed » Patch (to be ported)

Needs porting to 8.x-4.x.

fenstrat’s picture

fenstrat
he/him
Primary language English
Location Australia
commented
Version: 8.x-4.x-dev » 7.x-4.x-dev
Assigned: fenstrat » Unassigned
Status: Patch (to be ported) » Fixed

Committed and pushed 2e0f9d9 to 8.x-4.x. Thanks!

  • Commit 9865dff on 8.x-4.x authored by quicksketch, committed by fenstrat: 
    Issue #2246597 by quicksketch | nodecode: Extra slash being added to...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.