Closed (duplicate)
Project:
Webform
Version:
7.x-4.0-rc3
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
19 Apr 2014 at 05:21 UTC
Updated:
27 Aug 2014 at 21:45 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
quicksketchHere's a test patch to see if reverting #1878016: Allowing supporting modules hook onto the tests would fix this.
Comment #2
quicksketchComment #4
quicksketchHm, or I bet it's the dependency on CTools/Views that's causing this. I'm not sure how to specify dependencies yet. I'll need to do some research.
Comment #5
quicksketchComment #7
quicksketchComment #9
quicksketchHmm, my guess here is that CTools isn't being loaded as a dependency. From the http://drupal.org/project/testbot page:
My guess is that we need to specifically include the CTools dependency in the .info file, then wait for a new release, and retest. So based on that assumption, I've committed this patch and we can continue trying to test solutions after the next dev release is created.
Comment #11
quicksketchOkay, now that a new dev release is available, let's try this change again.
Comment #13
quicksketchLet's try this the other way around and remove the dependencies.
Comment #15
quicksketch13: webform_fix_tests-13.patch queued for re-testing.
Comment #18
quicksketchArg, I've been testing on the wrong branch. Let's try this again.
Comment #19
quicksketch13: webform_fix_tests-13.patch queued for re-testing.
Comment #20
quicksketch11: webform_fix_tests-9.patch queued for re-testing.
Comment #21
quicksketchNow testbot seems stuck :P
Here's patch #13 again.
Comment #22
quicksketchDeleted a bunch of tests, we'll see if it can pick up these again.
Comment #23
quicksketchSince testbot can't seem to test 7.x-4.x, let's try this against RC3.
Comment #24
quicksketchComment #25
quicksketchYay, finally a pass. Good to know that our tests *have* been passing, it's just testbot choking on dependencies. :P
The passing patch in #24 (same as #13) just removed all the dependencies entirely, which isn't something we want to do. Here's #9 again, to see if it can pass with the dependencies in place.
Comment #27
danchadwick commentedAs per #2306521: Declaration of WebformComponentsTestCase::setUp() should be compatible with WebformTestCase, consider using test_dependency in the .info file. Just documenting the tidbit.
Comment #28
hass commented#2306521: Declaration of WebformComponentsTestCase::setUp() should be compatible with WebformTestCase
The patch here is wrong code.