For the last couple of weeks, all patches submitted to testbot fail due a "Fatal error". Take the example of #2244975: Compatibility with jQuery 1.9+ (use of $.fn.attr), which is just JS changes. The test results give 3 errors:

  • The test did not complete due to a fatal error.
  • Enabled modules: webform
  • Invalid permission access own webform submissions.

This may have been introduced by #1878016: Allowing supporting modules hook onto the tests, which was the only issue recently I can think of that affected tests.

Comments

quicksketch’s picture

StatusFileSize
new720 bytes

Here's a test patch to see if reverting #1878016: Allowing supporting modules hook onto the tests would fix this.

quicksketch’s picture

Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, 1: webform_fix_tests-2244979.patch, failed testing.

quicksketch’s picture

Hm, or I bet it's the dependency on CTools/Views that's causing this. I'm not sure how to specify dependencies yet. I'll need to do some research.

quicksketch’s picture

Status: Needs work » Needs review
StatusFileSize
new594 bytes

Status: Needs review » Needs work

The last submitted patch, 5: webform_fix_tests-2244979-4.patch, failed testing.

quicksketch’s picture

Status: Needs work » Needs review
StatusFileSize
new884 bytes

Status: Needs review » Needs work

The last submitted patch, 7: webform_fix_tests-7.patch, failed testing.

quicksketch’s picture

StatusFileSize
new290 bytes

Hmm, my guess here is that CTools isn't being loaded as a dependency. From the http://drupal.org/project/testbot page:

I changed dependencies in my .info file, but the wrong dependencies are still being loaded on test Dependencies only get built when the new dev release is rolled, every 12 hours. So if you change dependencies, it won't be reflected until the new dev tarball is rolled.

My guess is that we need to specifically include the CTools dependency in the .info file, then wait for a new release, and retest. So based on that assumption, I've committed this patch and we can continue trying to test solutions after the next dev release is created.

  • Commit a57f90e on 7.x-4.x by quicksketch:
    Issue #2244979: Add CTools dependency explicitly for the sake of testbot...
quicksketch’s picture

Status: Needs work » Needs review
StatusFileSize
new594 bytes

Okay, now that a new dev release is available, let's try this change again.

Status: Needs review » Needs work

The last submitted patch, 11: webform_fix_tests-9.patch, failed testing.

quicksketch’s picture

Status: Needs work » Needs review
StatusFileSize
new351 bytes

Let's try this the other way around and remove the dependencies.

Status: Needs review » Needs work

The last submitted patch, 13: webform_fix_tests-13.patch, failed testing.

quicksketch’s picture

Status: Needs work » Needs review

13: webform_fix_tests-13.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, 13: webform_fix_tests-13.patch, failed testing.

The last submitted patch, 9: webform_fix_tests-9.patch, failed testing.

quicksketch’s picture

Version: 7.x-4.0-rc1 » 7.x-4.x-dev
Status: Needs work » Needs review

Arg, I've been testing on the wrong branch. Let's try this again.

quicksketch’s picture

13: webform_fix_tests-13.patch queued for re-testing.

quicksketch’s picture

11: webform_fix_tests-9.patch queued for re-testing.

quicksketch’s picture

StatusFileSize
new351 bytes

Now testbot seems stuck :P

Here's patch #13 again.

quicksketch’s picture

StatusFileSize
new594 bytes

Deleted a bunch of tests, we'll see if it can pick up these again.

quicksketch’s picture

Version: 7.x-4.x-dev » 7.x-4.0-rc3

Since testbot can't seem to test 7.x-4.x, let's try this against RC3.

quicksketch’s picture

StatusFileSize
new351 bytes
quicksketch’s picture

StatusFileSize
new594 bytes

Yay, finally a pass. Good to know that our tests *have* been passing, it's just testbot choking on dependencies. :P

The passing patch in #24 (same as #13) just removed all the dependencies entirely, which isn't something we want to do. Here's #9 again, to see if it can pass with the dependencies in place.

Status: Needs review » Needs work

The last submitted patch, 25: webform_fix_tests-9.patch, failed testing.

danchadwick’s picture

As per #2306521: Declaration of WebformComponentsTestCase::setUp() should be compatible with WebformTestCase, consider using test_dependency in the .info file. Just documenting the tidbit.

hass’s picture

Status: Needs work » Closed (duplicate)