In several JS files in Webform we're using the $.fn.attr method to check the disabled/checked state of elements. Unfortunately, this usage of $.fn.attr is incorrect as of jQuery 1.9, and using it can lead to inconsistent results. To solve this, we should check if $.fn.prop exists and use it to check/set these properties. For more information, see http://api.jquery.com/prop.

Comments

Status: Needs review » Needs work

The last submitted patch, webform_jquery_19_compatibility.patch, failed testing.

quicksketch’s picture

Status: Needs work » Fixed

Pushed to 7.x-4.x branch.

  • Commit a1640de on 7.x-4.x by quicksketch:
    Issue #2244975 by quicksketch: Compatibility with jQuery 1.9+ (use of $....
fenstrat’s picture

Version: 7.x-4.0-rc1 » 8.x-4.x-dev
Assigned: Unassigned » fenstrat
Status: Fixed » Patch (to be ported)

Needs porting to 8.x-4.x.

fenstrat’s picture

Version: 8.x-4.x-dev » 7.x-4.0-rc1
Assigned: fenstrat » Unassigned
Status: Patch (to be ported) » Fixed

Committed and pushed a1640de to 8.x-4.x. Thanks!

  • Commit cef1c41 on 8.x-4.x authored by quicksketch, committed by fenstrat:
    Issue #2244975 by quicksketch: Compatibility with jQuery 1.9+ (use of $....

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.