In reference to #2129997: Remove discount inline conditions here is a patch that moves all of the inline conditions related to Commerce Discount into the module.
| Comment | File | Size | Author |
|---|---|---|---|
| #15 | add_inline_conditions-2244969-15.patch | 2.63 KB | das-peter |
In reference to #2129997: Remove discount inline conditions here is a patch that moves all of the inline conditions related to Commerce Discount into the module.
| Comment | File | Size | Author |
|---|---|---|---|
| #15 | add_inline_conditions-2244969-15.patch | 2.63 KB | das-peter |
Comments
Comment #1
mglamanHere is said patch.
Comment #2
ralt commentedI've tested applying both #2244969 and #2129997 succesfully. Everything I've tested keeps working. Commits here (for inline_conditions) and here (for commerce_discount) if one wants to cherry-pick the commits.
(Cross-post of https://www.drupal.org/node/2129997#comment-9228091)
Comment #3
ralt commenteddouble-submitComment #4
ralt commentedComment #5
das-peter commentedI think we should take the opportunity and ensure default settings are set. Right now those functions tend to throw notices which breaks ajax calls :|
Updated patch attached, it introduces default settings and adds some conditions to avoid notices.
Comment #6
ralt commentedComment #7
joelpittetI'm a fan of the defaults with unions:)
Comment #8
andyg5000Just wrote #2424843: Inline condition for a product discount when product and quantity are matched that depends on this and adds a product discount condition to match product and quantity of a line item
Comment #9
deggertsen commentedThis fixed my problem with the conditions not loading at all after installing the module. Thank you! +1 RTBC
Comment #10
bojanz commentedCommitted, thanks!
Comment #12
joelpittet@bojanz thanks for commiting this:)
commerce_discount.inline_conditions.incdoesn't exist in 7.x-1.x branch It looks like the new file got missed in the commit.Comment #13
joelpittetHere's a patch with the missing file if that helps any.
Comment #14
bojanz commentedD'oh, repushed.
Comment #15
das-peter commentedOh darn, looks like I forgot to update the patch with the default values :|
This
should be
Comment #16
joelpittetThanks for spotting that so quickly @das-peter, I've committed it.