Comments

mglaman’s picture

StatusFileSize
new33.01 KB

Here is said patch.

ralt’s picture

I've tested applying both #2244969 and #2129997 succesfully. Everything I've tested keeps working. Commits here (for inline_conditions) and here (for commerce_discount) if one wants to cherry-pick the commits.

(Cross-post of https://www.drupal.org/node/2129997#comment-9228091)

ralt’s picture

double-submit

ralt’s picture

Status: Needs review » Reviewed & tested by the community
das-peter’s picture

StatusFileSize
new32.68 KB
new4.73 KB

I think we should take the opportunity and ensure default settings are set. Right now those functions tend to throw notices which breaks ajax calls :|
Updated patch attached, it introduces default settings and adds some conditions to avoid notices.

ralt’s picture

Status: Reviewed & tested by the community » Needs review
joelpittet’s picture

Status: Needs review » Reviewed & tested by the community

I'm a fan of the defaults with unions:)

andyg5000’s picture

Just wrote #2424843: Inline condition for a product discount when product and quantity are matched that depends on this and adds a product discount condition to match product and quantity of a line item

deggertsen’s picture

This fixed my problem with the conditions not loading at all after installing the module. Thank you! +1 RTBC

bojanz’s picture

Status: Reviewed & tested by the community » Fixed

Committed, thanks!

  • bojanz committed 4b516cd on 7.x-1.x authored by mglaman
    Issue #2244969 by das-peter, mglaman: Add inline conditions from...
joelpittet’s picture

Status: Fixed » Needs work

@bojanz thanks for commiting this:)

commerce_discount.inline_conditions.inc doesn't exist in 7.x-1.x branch It looks like the new file got missed in the commit.

joelpittet’s picture

Status: Needs work » Reviewed & tested by the community
StatusFileSize
new17.88 KB

Here's a patch with the missing file if that helps any.

bojanz’s picture

Status: Reviewed & tested by the community » Fixed

D'oh, repushed.

das-peter’s picture

Status: Fixed » Reviewed & tested by the community
StatusFileSize
new2.63 KB

Oh darn, looks like I forgot to update the patch with the default values :|
This

  $settings = array(
     'operator' => '>=',
     'total' => array('amount' => 0),
  ) + $settings;

should be

  $settings += array(
     'operator' => '>=',
     'total' => array('amount' => 0),
  );
joelpittet’s picture

Status: Reviewed & tested by the community » Fixed

Thanks for spotting that so quickly @das-peter, I've committed it.

  • joelpittet committed f2d111c on 7.x-1.x authored by das-peter
    Issue #2244969 by das-peter: Fix defaults settings for inline_conditions
    

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.