Closed (fixed)
Project:
Linkit
Version:
7.x-3.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
15 Apr 2014 at 14:16 UTC
Updated:
29 Apr 2014 at 21:00 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
jay.dansand commentedEnabling CSS aggregation solves the problem, but isn't always possible. Attached is a patch that disables preprocessing on both CSS files, which solves the issue in a more modular fashion.
Comment #2
anonNot sure if the patch really solves this issue in the correct way. The base issue here is the limitation of css files in IE. See http://blogs.msdn.com/b/ieinternals/archive/2011/05/14/10164546.aspx
Do you mean that settings "preprocess" to true will solve this but isn't always possible? Why not?
Comment #3
jay.dansand commentedEnabling CSS aggregation will solve the problem, but isn't always possible. It's always possible to selectively turn off preprocessing, which is what the patch in #1 does, and that solves the problem. Read on for why.
This is not the
@importlimit bug you mentioned. I'm aware of that bug, but there are nowhere near 31@imports, nor are there nested@imports. I can replicate this on a stock Drupal instance with the Bartik theme, and the only modules enabled are CKEDITOR, Libraries, and LinkIt.The only meaningful changes between Drupal's outputs pre-patch and post-patch are in the JSON returned by the AJAX POST to linkit/dashboard. Specifically, in the insert command:
Broken in IE 9:
Working in IE 9:
As you can see, the only difference is the pre-patch JSON inserts a
styletag with@import, and the post-patch returns alinktag. Just to be sure, I dumped the DOM after invoking LinkIt, and even counted the outer document as well as alliframes within it, then counted all @imports: there were 27.Actually, it's a known bug with Internet Explorer that after the initial page processing, dynamically created style elements will not be evaluated (you need to use the old
createStyleSheetmethod: http://msdn.microsoft.com/en-us/library/ms531194%28VS.85%29.aspx).You can readily replicate the bug (there will only be one
@importhere, so it's definitely a different problem):dynamic_style_ie_broken.html
dynamic_style_ie_broken.css
The above example works in everything but IE.
Comment #5
anonThanks for the patch. I have commited it.
Comment #6
jay.dansand commentedHooray! Thanks much, and especially for the quick turnaround!