Although there is no stable release of feeds recently, but there are some fixes in its latest dev version.

There is one API function change regarding set target callback function that the type of target value passed through has been change from string to array.

Comments

eric.chenchao’s picture

Here is a patch to make domain_feeds work with the latest dev of feeds.

steveoriol’s picture

Here's another patch that works better for me

eric_a’s picture

Status: Active » Needs review
StatusFileSize
new1.44 KB
new972 bytes

Just a re-roll of #1.

eric_a’s picture

Version: 7.x-1.1 » 7.x-1.2
eric_a’s picture

Category: Support request » Task

Guess this is a task, for now. To become a bug with a new release of Feeds.

eric_a’s picture

Status: Needs review » Needs work
Issue tags: +Needs reroll
Related issues: +#2300331: Domain mapping is cumbersome.
eric_a’s picture

Title: Make domain_feeds work with the latest dev of feeds » Make domain_feeds work with the latest release of feeds
Version: 7.x-1.2 » 7.x-1.x-dev
Category: Task » Bug report
Status: Needs work » Needs review
StatusFileSize
new1.21 KB
new2.02 KB

Quick reroll for #2300331: Domain mapping is cumbersome. and #1254586: Source domain

With the release of feeds-7.x-2.0-beta1 this issue needs to be resolved for domain_feeds to work with the current recommended release of feeds.

If we want to we can easily add BC for feeds 2.0-alpha9 / 2.0-alpha8.

If we don't then we should probably just add array type hinting.

eric_a’s picture

Issue tags: -Needs reroll
eric_a’s picture

Assigned: Unassigned » eric_a
Status: Needs review » Needs work

Oops, some important parts are missing in #7. Will post a new patch.

eric_a’s picture

Assigned: eric_a » Unassigned
Status: Needs work » Needs review
StatusFileSize
new583 bytes
new2.31 KB

This just fixes the bug in #7.

eric_a’s picture

Right, the earlier patches already added the array type hinting, so let's add them to the new 1.3 callback functions as well for consistency.

  • Jim.M committed e7701a8 on 7.x-1.x authored by Eric_A
    Issue #2240163 by Eric_A, eric.chenchao, steveoriol: Make domain_feeds...
jim.m’s picture

Status: Needs review » Fixed

Thanks for the patches. Enjoy new release version of the module.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.