Currently, a REQUIREMENT_WARNING raised during an interactive install causes the same message text to appear as a REQUIREMENT_ERROR (namely, "Check the messages and try again"), except that in the latter case, "try again" means to re-attempt the checks, while in the former, it means to bypass the checks altogether.

The attached patch disambiguates what will happen by creating a very clear difference in the system's output for the two cases, including two separate links in the warning case, one for each of the desirable actions: either repeat the tests, or ignore the warning and continue.

To reproduce: raise a REQUIREMENT_WARNING in install.php. Offhand, it looks like not having full Unicode support might do it, but I was doing it by just injecting a failure manually.

Contributor tasks needed
Task Novice task? Contributor instructions Complete?
Create a patch Instructions Yes
Reroll the patch if it no longer applies. Novice Instructions
Update the issue summary Instructions
Add automated tests Instructions
Manually test the patch Novice Instructions
Review patch to ensure that it fixes the issue, stays within scope, is properly documented, and follows coding standards Instructions
CommentFileSizeAuthor
#12 drupal-improve_installer-2240021-12.patch1.46 KBswarad07
#7 drupal-improve_installer-2240021-7.patch1.46 KBpingwin4eg
#4 installer-2240021-4.patch1.58 KBquartsize
installer-BMDan-20140413-01.patch1.57 KBBMDan

Comments

BMDan’s picture

BMDan commented
Title: Improve Installer REQUIREMENTS_WARNING Messaging » Improve Installer REQUIREMENT_WARNING Messaging
BMDan’s picture

BMDan commented
Issue summary: View changes
Issue tags: +Novice
quartsize’s picture

quartsize commented

Investigating...

One can also simulate a REQUIREMENT_WARNING by adding mb_strlen to disable_functions in php.ini.

quartsize’s picture

quartsize commented
Category: Feature request » Bug report
Status: Active » Reviewed & tested by the community
Issue tags: +Needs backport to D7
StatusFileSize
new installer-2240021-4.patch1.58 KB
  1. I think this is more of a usability bugfix than a feature.
  2. I'm attaching a new patch, but the only difference is a style fix (else on new line).
  3. The reason the original and new patch change "Requirements problem" to "Requirements review" and "try again" to "retry" when there's just a REQUIREMENT_WARNING is to increase the distinctiveness.
  4. Going straight from active to rtbc because it's BMDan's patch and he had meant to mark it needs review.
  5. There is a similar language issue in 7.x also.
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Version: 8.x-dev » 7.x-dev
Status: Reviewed & tested by the community » Patch (to be ported)

@quartsize thanks for working on this. It would be great to add an interdiff to prove the differences between your patch and BMDan's. For instructions on creating an interdiff, see https://drupal.org/documentation/git/interdiff | Microbranching workflow: http://xjm.drupalgardens.com/blog/interdiffs-how-make-them-and-why-they-...

  • Commit 17ccb8b on 8.x by alexpott: 
    Issue #2240021 by BMDan, quartsize: Fixed Improve Installer...
pingwin4eg’s picture

pingwin4eg
Location Zaporizhia 🇺🇦
commented
Status: Patch (to be ported) » Needs review
StatusFileSize
new drupal-improve_installer-2240021-7.patch1.46 KB

Here's the D7 patch.

Status: Needs review » Needs work

The last submitted patch, 7: drupal-improve_installer-2240021-7.patch, failed testing.

ashishdalvi’s picture

ashishdalvi
Primary language English
Location Mumbai
commented
Status: Needs work » Needs review

Patch failed in bot testing. But it have passed all the testcases.

Adding path for Re-Testing.

The last submitted patch, installer-BMDan-20140413-01.patch, failed testing.

swarad07’s picture

swarad07
Primary language English
Location Navi Mumbai, India
commented
Status: Needs review » Needs work
swarad07’s picture

swarad07
Primary language English
Location Navi Mumbai, India
commented
Status: Needs work » Needs review
StatusFileSize
new drupal-improve_installer-2240021-12.patch1.46 KB

No idea why the patch is failing. Uploading again.

  • alexpott committed 17ccb8b on 8.3.x 
    Issue #2240021 by BMDan, quartsize: Fixed Improve Installer...

  • alexpott committed 17ccb8b on 8.3.x 
    Issue #2240021 by BMDan, quartsize: Fixed Improve Installer...
stefan.r’s picture

stefan.r commented
Issue tags: +Dublin2016, +Needs screenshots, +Needs manual testing
hesnvabr’s picture

hesnvabr commented

I applied this patch.It passed all the testcases

hesnvabr’s picture

hesnvabr commented
Status: Needs review » Reviewed & tested by the community
hesnvabr’s picture

hesnvabr commented
panshulk’s picture

panshulk commented
Assigned: Unassigned » panshulk
panshulk’s picture

panshulk commented
Assigned: panshulk » Unassigned
stefan.r’s picture

stefan.r commented
Status: Reviewed & tested by the community » Needs review

Thanks -- can we have some screenshots on what this looks like in D7 (with the patch applied) versus D8, in both the "problem" and "review" cases?

  • alexpott committed 17ccb8b on 8.4.x 
    Issue #2240021 by BMDan, quartsize: Fixed Improve Installer...

  • alexpott committed 17ccb8b on 8.4.x 
    Issue #2240021 by BMDan, quartsize: Fixed Improve Installer...

Status: Needs review » Closed (outdated)

Automatically closed because Drupal 7 security and bugfix support has ended as of 5 January 2025. If the issue verifiably applies to later versions, please reopen with details and update the version.