Closed (fixed)
Project:
Panopoly
Version:
7.x-1.x-dev
Component:
Core
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
13 Apr 2014 at 11:46 UTC
Updated:
1 Jun 2014 at 08:20 UTC
Jump to comment: Most recent
There is a new version of the "state" patch for pathauto available here:
https://drupal.org/comment/8674137#comment-8674137
And according to @plethoradesign this fixes an issue with Panopoly:
I'm using Panopoly and was unaware that the patch from #130 was included. I was having an issue when customizing pages with the in-place editor, where it would reset the page's alias automatically afterwards. I tested the patch from #178 and that fixed it for me.
Comments
Comment #1
dsnopekComment #2
caspervoogt commentedSteps to recreate the issue;
- create a page and give it a custom alias. Having "Generate automatic URL alias" checked or unchecked seemed to make no difference.
- go to this page and click "Customize this page" button.
- make some changes and save
- it returns me to the page, with its correct alias that I set previously.
- I visit the page again or reload it, and at this point it reverts to its auto-generated alias rather than the one I set manually. I then have to edit the page (with the usual Edit tab rather than using Panopoly) and set its alias manually again, and because I have the Redirect module enabled I also need to remove the redirect pointing to itself, which causes an infinite loop.
I did apply the patch from https://drupal.org/comment/8674137#comment-8674137 and that solved it for me.
Comment #3
lsolesen commentedHere is a Behat test for path auto where I tried describing your use case. https://github.com/lsolesen/panopoly/blob/pathauto/tests/behat/features/...
However, I cannot get the test to fail. Did I do anything wrong with it?
Comment #4
dsnopek@lsolesen: I haven't tried this myself, but just based on @plethoradesign's steps above, I think you need to reload the page after waiting for the Panels IPE to deactivate.
Comment #5
lsolesen commented@dsnopek I thought it would be the same to just click View. Not failing even thought I change to " When I reload the page"
Comment #6
dsnopek@lsoleson: Ah, you're right clicking "View" would be the same! Sorry, I missed that. :-)
Comment #7
caspervoogt commented" I think you need to reload the page after waiting for the Panels IPE to deactivate."
Yes, after reloading the alias gets changed, at least for me prior to the patch at https://drupal.org/comment/8674137#comment-8674137 .
I would say though, as far as testing goes... I was dealing with an existing node that I was editing. Not adding a node. Don't know if it makes a difference. My node already had an alias, which I wanted to leave alone, but editing via Panels "Customize this page" and then saving "as custom" even after making no changes, then reloading the page caused the alias to revert to an automatic alias.
Comment #8
dsnopekAn idea just came to me with regard to the Behat test: maybe the reload is "working" but it's giving a 404 page?
@lsolesen: Can you check for more than just the URL after reloading? Or maybe even try to click the "Edit" tab and verify that the field has the correct value?
Comment #9
lsolesen commentedMakes no difference. Do not have time to create a patch, but the test is available on https://github.com/lsolesen/panopoly/blob/pathauto/tests/behat/features/... if you want to try it.
Maybe pathauto used to not really save the path properly (hence pathauto_persist), but it has been fixed in the version Panopoly is using now, so we can not get it to fail?
Comment #10
dsnopekThanks, @lsolesen! I'll give it a try this weekend. :-)
Comment #11
dsnopek@plethoradesign: Following your steps in #2, I'm unable to reproduce this error by hand with a fresh install of Panopoly 1.2. Can you confirm that you can reproduce on plain Panopoly 1.2? Or does it only happen your built out site with other modules and configuration?
Comment #12
dsnopekI just want to note: whether or not we can reproduce this problem, we probably should review the new patch on the pathauto issue and RTBC it again if the changes look good. Unfortunately, the author of the new patch didn't include an interdiff which makes it a little harder to review.
Comment #13
caspervoogt commented@dsnopek. I haven't yet had a chance to try on a fresh, plain Panopoly 1.2. So it is entirely possible this is down to odd interactions with some other module(s).
Comment #14
dsnopekThere was just an even newer version of this patch added here:
https://drupal.org/node/936222#comment-8770937
This version MAY fix an upgrade issue that has plagued us for a really long time: #2164193: Upgrade from 1.0-rc5 fails: Table 'pathauto_state' doesn't exist
Comment #15
dsnopekI tested the new patch and it not only works just fine, it also helps with the upgrade issues!
Committed. :-)