Views GroupwiseMax class calls protected properties

Not sure about @todo and type => tag, but the patch at least allows open settings form

PS: Faced in #1498660: Refactor taxonomy entity properties to multilingual

a bit more fixes

PS: no idea how to write test

@ivanjaros: yes not everything needs a test but something that exposes a list of views to users does.

Oh and recreating this error is easy.

1. Create a view on taxonomy terms
2. Add a relationship to "Representative node" and you'll never be able to edit that relationship because of this bug. Views UI's js will hide the bug if you go to admin/structure/views/nojs/handler/VIEW_ID/default/relationship/tid_representative you'll see the bug plain as day.

There's 2 views tests named RelationshipRepresentativeNodeTest
they uses test_groupwise_term and test_groupwise_user views

re #7 but the tests never visit the configuration forms so we don;t have test coverage of the bug.

This is a critical issue, or at least Major. If you go to Views UI and try to view the settings for a GroupwiseMax relationship field (such as Representative Node for a Taxonomy Term view), you get a fatal PHP error.

And yes it needs a test.

Working on the test.

The test "test_groupwise_term_ui" basically is a copy of "test_groupwise_term".

This is a first attempt :) . There's an Exception when we apply the changes. (Uncaught PHP Exception Symfony\Component\DependencyInjection\Exception\ServiceNotFoundException: "You have requested a non-existent service "cache.views_results"." at /Users/josemanuelrodriguez/workspace/drupal8/core/vendor/symfony/dependency-injection/Symfony/Component/DependencyInjection/Container.php line 303)

Missing the view, sorry.

About the Exception (#11) we can avoid it removing the line "\Drupal::cache('views_results')->delete($cid);"

So we need to test this too.

I was talking about this bug with tstoeckler and we are not sure if we really need it...

I was talking with dawhener and let's use "cache.data" instead.

Added test for the cache.

Awesome!

1. +++ b/core/modules/views/src/Plugin/views/relationship/GroupwiseMax.php
   @@ -122,20 +123,14 @@ public function buildOptionsForm(&$form, FormStateInterface $form_state) {
   -    $all_views = Views::getAllViews();
   -    foreach ($all_views as $view) {
   +    foreach (Views::getAllViews() as $view) {
   

   +1

2. +++ b/core/modules/views/src/Plugin/views/relationship/GroupwiseMax.php
   @@ -122,20 +123,14 @@ public function buildOptionsForm(&$form, FormStateInterface $form_state) {
   -        if ($view->type == 'Default') {
   -          $views[t('Default Views')][$view->storage->id()] = $view->storage->id();
   -        }
   -        else {
   -          $views[t('Existing Views')][$view->storage->id()] = $view->storage->id();
   -        }
   

   oh wow, this is damn old code!

Committed 2c11d0e and pushed to 8.0.x. Thanks!