The twitter API returns a language code for each tweet. It would be useful to have this retrieved to aid with styling of rtl languages and filtering of views in multilingual sites.

patch to add this functionality to 7.58 attached.

CommentFileSizeAuthor
#6 2238765-5.patch2.9 KBstefan.r
#3 2238765-3.patch2.9 KBstefan.r
twitter-langcode-D7.patch2.5 KBstephenn

Comments

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Version: 7.x-5.8 » 7.x-5.x-dev
Status: Active » Needs review

Thanks for providing a patch. Please try to remember to set the status to "needs review" when you upload a patch, that way others know there's a patch to look at, otherwise it might be overlooked.

Status: Needs review » Needs work

The last submitted patch, twitter-langcode-D7.patch, failed testing.

stefan.r’s picture

stefan.r commented
StatusFileSize
new 2238765-3.patch2.9 KB

Re-roll.

stefan.r’s picture

stefan.r commented
Title: Record iso language code from api » Ability to use language code from API
Priority: Normal » Major
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 3: 2238765-3.patch, failed testing.

stefan.r’s picture

stefan.r commented
Status: Needs work » Needs review
StatusFileSize
new 2238765-5.patch2.9 KB
stefan.r’s picture

stefan.r commented

Tested the views filter and the filtering by tweet language works great. The only thing is it expects you to enter the langcode manually (as a string) rather than listing the standard langcode options (i.e. "Current user's language" etc). Maybe can be tackled in a followup as this is not extremely problematic and it's better to have something rather than nothing :)