Problem/Motivation

After clicking get path the input box with the path appears twice.

It seems this is due to the click function getting bound twice.

Proposed resolution

Use once() before binding the click function in search_krumo.trail.js

CommentFileSizeAuthor
#1 click_bound_twice-2238753-1.patch781 bytesdahousecat
krumo-2-input-boxes.jpg40 KBdahousecat

Comments

dahousecat’s picture

dahousecat commented
StatusFileSize
new click_bound_twice-2238753-1.patch781 bytes

I've made a patch (my first ever patch!)

Only changed one line so starting simple...

dahousecat’s picture

dahousecat commented
Status: Active » Needs review
moymilo’s picture

moymilo commented
Status: Needs review » Needs work

Could not reproduce the error, but the patch is working fine, and I think it should be added.

moymilo’s picture

moymilo commented
Status: Needs work » Needs review
moymilo’s picture

moymilo commented
Status: Needs review » Reviewed & tested by the community
bramtenhove’s picture

bramtenhove commented

Great, thanks for the patch and reviewing it! I will commit it and create a new version soon.

bramtenhove’s picture

bramtenhove commented
Assigned: Unassigned » bramtenhove

  • bramtenhove committed ecd732e on 7.x-1.x authored by dahousecat 
    Issue #2238753 by dahousecat: Upon clicking get path input box with path...
bramtenhove’s picture

bramtenhove commented
Status: Reviewed & tested by the community » Fixed

Thanks for the patch. Has just been committed!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.