Now that #2142903: Port to Drupal 8 has been fixed the port to Drupal 8 is unblocked. Assigning to version 7.x-1.0-beta1 for now since there's no 8.x branch yet.

CommentFileSizeAuthor
#5 Screen Shot 2017-10-12 at 9.06.00 AM.png307 KBmgifford
#4 pasc-drupal_8-2237493-4.patch17.33 KBshkiper
#2 pasc-Drupal_8-2237493-2.patch17.71 KBshkiper

Issue fork pasc-2237493

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

traviscarden’s picture

traviscarden commented
Version: 7.x-1.0-beta1 » 8.x-1.x-dev

Thanks, @anavarre. Given that the entire functionality of this module is an implementation of one hook from Checklist API that didn't change in the port to Drupal 8, upgrading the code here will be trivial. The interesting problem will be content--capturing and codifying performance and scalability best practices for Drupal 8, specifically. The question of content in general is taking place in #1851802: Module Feedback & Suggestions. Input is welcome highly desired there. Perhaps in this issue we can discuss the question relative to Drupal 8 in particular.

shkiper’s picture

shkiper commented
Status: Active » Needs review
StatusFileSize
new pasc-Drupal_8-2237493-2.patch17.71 KB

Hi, I made a version of this module that works with Drupal 8 beta
Here is my patch

anavarre’s picture

anavarre
Primary language French
Location 🇪🇺
commented
Status: Needs review » Needs work

@andrii zahura thanks for the patch. However I think @TravisCarden wanted to continue the discussion in #1851802: Module Feedback & Suggestions first before working on the port, simply because we don't yet know where it'll be going.

That being said, I did try to apply the patch and test, but it fails on installing the module with the below error (missing route):

[Tue Jan 27 15:49:56.362613 2015] [:error] [pid 2278] [client 127.0.0.1:60402] Uncaught PHP Exception Twig_Error_Runtime: "An exception has been thrown during the rendering of a template ("Route "checklistapi.checklists.pasc" does not exist.") in "core/modules/system/templates/menu.html.twig" at line 36." at /var/www/html/d8/core/vendor/twig/twig/lib/Twig/Template.php line 294, referer: http://d8.local/admin/modules

shkiper’s picture

shkiper commented
Status: Needs work » Needs review
StatusFileSize
new pasc-drupal_8-2237493-4.patch17.33 KB

I fixed installation error. Please check my new patch

mgifford’s picture

mgifford
he/him
Primary language English
commented
StatusFileSize
new Screen Shot 2017-10-12 at 9.06.00 AM.png307 KB

So someone needs to step up to be the maintainer of this project from the sounds of it. I don't really have the bandwidth, but would like to see this move ahead. As Ben pointed out it ties in closely to an article I've written here on sustainability http://openconcept.ca/blog/mike/tips-sustainable-drupal-7-8-website

There is actually a strong connection between performance & sustainability, but not what first comes to mind for most folks.

That being said I tested @shkiper patch of a year ago in D8 and it seems to work - /admin/config/development/pasc

screen capture of report page

What needs to happen to roll this up into a D8 release?

traviscarden’s picture

traviscarden commented

Hey, @mgifford. As expressed in the comments above, the question here is entirely one of expert content and, by extension, project ownership. I have no ongoing interest in the module, personally. If you're interested in taking it over, please let me know.

the_g_bomb made their first commit to this issue’s fork.

the_g_bomb opened merge request !1

traviscarden’s picture

traviscarden commented

Thank you, @the_g_bomb. This module is unsupported. If you would like to take ownership of it, I'd be happy to transfer it to you.

the_g_bomb’s picture

the_g_bomb commented

Happy to keep it going, but not sure how much investigation I can do. I will implement things for others if needs be.

traviscarden’s picture

traviscarden commented

Sounds good, @the_g_bomb. I've added you to the project maintainers. Enjoy. :)

@anavarre, since you're a maintainer here, too, I haven't given @the_g_bomb administer maintainers permission. If you aren't interested in being a maintainer anymore, we can give the whole thing over to him.

the_g_bomb’s picture

the_g_bomb commented

I have updated this somewhat recently, I will produce a full release when the recent ci tools are merged and all ok.

I'll need more permissions to update the project page.

@anavarre If you aren't interested in being a maintainer anymore, I am happy take over the whole thing. I'll hopefully be able to update this over the next while. If nothing else, I'm happy to add patches and keep it running.

the_g_bomb’s picture

the_g_bomb commented
Status: Needs review » Fixed

I am going to close this task and keep open the suggestions if anyone needs new features added, they can be done there. There is a D8+ version available now so this is closing.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.