The $filter argument in _webform_render_file() and other _webform_render_* callbacks is used by Form Builder to generate a raw editable version of the element. Right now we're adding the file upload help all the time, making it so if you edit a file component with Form Builder, you end up editing the file upload help. Every time you edit, more help gets appended to the description. This description should not be part of the editable configuration, so it should be skipped when $filter === FALSE.

CommentFileSizeAuthor
webform_file_component_filter.patch821 bytesquicksketch
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Status: Needs review » Needs work

The last submitted patch, webform_file_component_filter.patch, failed testing.

quicksketch’s picture

Status: Needs work » Fixed

Pushed to 7.x-4.x.

  • Commit 6ff7a78 on 7.x-4.x by quicksketch:
    Issue #2236247: File component upload description should be skipped if...
fenstrat’s picture

Version: 7.x-4.0-beta3 » 8.x-4.x-dev
Assigned: Unassigned » fenstrat
Status: Fixed » Patch (to be ported)

Needs porting to 8.x-4.x.

fenstrat’s picture

Version: 8.x-4.x-dev » 7.x-4.0-beta3
Assigned: fenstrat » Unassigned
Status: Patch (to be ported) » Fixed

Committed and pushed 6ff7a78 to 8.x-4.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.