Problem/Motivation

See #2223189: Use regular upstream HttpKernel instead of Drupal's custom

Proposed resolution

Instead of injecting request service, rather use the Symfony 2.4 request_stack in UrlCacheContext and ThemeCacheContext.

Remaining tasks

User interface changes

API changes

CommentFileSizeAuthor
#1 2236167-use-request-stack-in-cache-context.diff5.15 KBznerol

Comments

znerol’s picture

znerol commented
Status: Active » Needs review
Issue tags: +Quick fix
StatusFileSize
new 2236167-use-request-stack-in-cache-context.diff5.15 KB
znerol’s picture

znerol commented
Issue summary: View changes

Status: Needs review » Needs work

The last submitted patch, 1: 2236167-use-request-stack-in-cache-context.diff, failed testing.

znerol’s picture

znerol commented
Status: Needs work » Postponed

Ok, this looks like DUBT test failures and this is very likely fixed the same way as #2225605-8: Use request stack in form builder. Let's postpone it on #2228341: Objectify session management functions + remove session.inc.

znerol’s picture

znerol commented
Status: Postponed » Needs review
znerol’s picture

znerol commented

1: 2236167-use-request-stack-in-cache-context.diff queued for re-testing.

znerol’s picture

znerol commented

1: 2236167-use-request-stack-in-cache-context.diff queued for re-testing.

dawehner’s picture

dawehner
Primary language German
commented

It would be great if at least core comitters are aware of the deprecation of the request service.

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community

Still applies.

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.x, thanks!

  • Commit a8f43b0 on 8.x by catch: 
    Issue #2236167 by znerol: Use request stack in cache contexts.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.